Do not blanket-set include dirs and link libs #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all targets in the project necessarily depend on `Python.h` and `libpython`.
|
Good catch! Ugly stuff is going on in there :-) We need to revamp it :-) |
|
Agreed 😄
…On Fri, Mar 9, 2018 at 7:06 PM, Radovan Bast ***@***.***> wrote:
Good catch! Ugly stuff is going on in there :-) We need to revamp it :-)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#235 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADiXEQzaDsyw6IEtoE63C68U5ggJr0nUks5tcsSigaJpZM4SkpF7>
.
--
Roberto Di Remigio
|
|
What do you say we use the find Python libs module in PyBind11? |
|
The python tests are now new failing tests. Would you like me to look into that or will you have a look? |
|
About pybind11: you mean in the book? |
|
I meant copy-pasting this module into Autocmake: https://github.com/pybind/pybind11/blob/master/tools/FindPythonLibsNew.cmake It seems to be able to consistently find the right version of libraries given an interpreter (which the standard CMake module still struggles with) I'll look into the tests, I had committed though the web UI. |
|
Thanks! Now I understand - yes, sounds good. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all targets in the project necessarily depend on
Python.handlibpython.