Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tailwind version & prefix support #19

Closed
Mo7sin opened this issue Oct 28, 2019 · 6 comments
Closed

tailwind version & prefix support #19

Mo7sin opened this issue Oct 28, 2019 · 6 comments

Comments

@Mo7sin
Copy link

Mo7sin commented Oct 28, 2019

Hello,

I think adding support to add user's custom tailwind prefix would be useful, Many users nowadays are using tailwind with a custom prefix to avoid conflict with other frameworks.

basically class name like bg-green-lightest with my own prefix would be tw-bg-green-lightest

Also tailwind ^1.0 has changed class names, So the current class names like darkest, darker, light, lightest won't work!

Check this out Update any usage of text/bg/border-{color} classes

@mikeerickson
Copy link

I am confused, what are you proposing? Tailwind already supports class prefixes (it has been around since early days).

I am sure you are aware of this, this the reason for confusion.

@Mo7sin
Copy link
Author

Mo7sin commented Oct 29, 2019

@mikeerickson Yeah I'm aware that tailwind supports prefix, But This package doesn't allow users to use their own tailwind prefix, check this skin file for example left_accent_border

As you can see, there is no way for the user to apply any prefixes, I'm not sure view files can be published with this package or not!

I hope things are clear now.

EDIT: I've reinstalled the package and published its vendor files, and it's fully customizable, Sorry about that.

@Mo7sin Mo7sin closed this as completed Oct 29, 2019
@Mo7sin Mo7sin reopened this Oct 29, 2019
@Mo7sin
Copy link
Author

Mo7sin commented Oct 29, 2019

After a real-world test, it turns out that it's not picking up customized views from path resources/views/vendor/laraflash/components/skins/ is that an issue or it's intentional?

@hivokas
Copy link
Member

hivokas commented Oct 29, 2019

@Mo7sin it is not necessary to publish and modify default skins. They are given as a quick starting point. If they don't satisfy your needs - your can easily create your own skin in resources/views and put its name into the config file.

For example, you could create your skin at resources/views/partials/skin.blade.php and specify partials.skin as a value of the skin key inside laraflash.php config file.

@hivokas
Copy link
Member

hivokas commented Nov 9, 2019

@Mo7sin does it work well for you?

@Mo7sin
Copy link
Author

Mo7sin commented Nov 10, 2019

@hivokas Unfortunately, I didn't try that.

Maybe later and I will post my feedback, thank you :)

@Mo7sin Mo7sin closed this as completed Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants