Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable Release #8

Closed
hivokas opened this issue Jul 16, 2019 · 6 comments
Closed

Stable Release #8

hivokas opened this issue Jul 16, 2019 · 6 comments

Comments

@hivokas
Copy link
Member

hivokas commented Jul 16, 2019

I'm planning to publish a stable release.

Are there any breaking changes which should be done before this release?
@klimov-paul
Copy link
Contributor

You may consider renaming js_namespace to jsNamespace at config:
https://github.com/coderello/laravel-shared-data/blob/master/config/shared-data.php#L15

@hivokas
Copy link
Member Author

hivokas commented Jul 22, 2019

I think it's not a good idea. Because Laravel community uses snake case for config keys.

@klimov-paul
Copy link
Contributor

OK, then it is ready for 1.0.0.

@hivokas
Copy link
Member Author

hivokas commented Jul 22, 2019

Please, check my latest changes:
1b00097

@klimov-paul
Copy link
Contributor

I would not extract separate method hydrateConfig().
Other changes look fine.

@hivokas
Copy link
Member Author

hivokas commented Jul 23, 2019

Well, I've published the release.

@hivokas hivokas closed this as completed Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@klimov-paul @hivokas