New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I148 create admin role using firebase functions and restriction rules to firestore security rules #166
Merged
NicholasChoong
merged 51 commits into
main
from
i148-create_admin_role_using_firebase_functions_and_restriction_rules_to_firestore_security_rules
Jan 7, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i148-create_admin_role_using_firebase_functions_and_restriction_rules_to_firestore_security_rules
…i148-create_admin_role_using_firebase_functions_and_restriction_rules_to_firestore_security_rules
…i148-create_admin_role_using_firebase_functions_and_restriction_rules_to_firestore_security_rules
…i148-create_admin_role_using_firebase_functions_and_restriction_rules_to_firestore_security_rules
…triction_rules_to_firestore_security_rules' of https://github.com/codersforcauses/poops into i148-create_admin_role_using_firebase_functions_and_restriction_rules_to_firestore_security_rules
…triction_rules_to_firestore_security_rules' of https://github.com/codersforcauses/poops into i148-create_admin_role_using_firebase_functions_and_restriction_rules_to_firestore_security_rules
scratchclaggy
approved these changes
Jan 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
NicholasChoong
deleted the
i148-create_admin_role_using_firebase_functions_and_restriction_rules_to_firestore_security_rules
branch
January 7, 2023 05:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Need to update .env file
Related Issue