Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I142 integrate firebase into the home page #167

Merged
merged 16 commits into from Jan 2, 2023
Merged

I142 integrate firebase into the home page #167

merged 16 commits into from Jan 2, 2023

Conversation

justinliangg
Copy link
Collaborator

@justinliangg justinliangg commented Dec 30, 2022 •
edited by github-actions bot

Change Summary

  • Added a trigger to automatically update the user statistics on any changes made to the visit subcollection.
  • Added protection and display of user statistics on the homepage

Change Form

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

The trigger only works with the emulator enabled and does not currently work on the live server.
Paid plan will be needed to be able to deploy the functions.

Related Issue

@vercel
Copy link

vercel bot commented Dec 30, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
poops ✅ Ready (Inspect) Visit Preview Jan 2, 2023 at 3:51AM (UTC)

scratchclaggy
scratchclaggy requested changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@scratchclaggy scratchclaggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just a couple notes to handle on the index page and summary component. It's mostly about moving anything specific to the summary out of the index page and reducing the amount of function calls in index.

I'll leave reviewing the triggers to @NicholasChoong

src/components/Home/summary.tsx Outdated Show resolved Hide resolved
src/pages/index.tsx Outdated Show resolved Hide resolved
src/pages/index.tsx Outdated Show resolved Hide resolved
scratchclaggy
scratchclaggy previously approved these changes Jan 1, 2023
View reviewed changes
Copy link
Contributor

@scratchclaggy scratchclaggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with all the React/Typescript stuff, nice work 🚀

@justinliangg
Copy link
Collaborator Author

Thank you for the review @scratchclaggy!

NicholasChoong
NicholasChoong previously approved these changes Jan 2, 2023
View reviewed changes
Copy link
Member

@NicholasChoong NicholasChoong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! The trigger function works flawlessly.

firebase/package.json Outdated Show resolved Hide resolved
firebase/functions/visitTrigger.ts Outdated Show resolved Hide resolved
NicholasChoong
NicholasChoong approved these changes Jan 2, 2023
View reviewed changes
Copy link
Member

@NicholasChoong NicholasChoong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@justinliangg
Copy link
Collaborator Author

@NicholasChoong Thanks for the review 😊

@justinliangg justinliangg merged commit bc6033e into main Jan 2, 2023
@NicholasChoong
Copy link
Member

All g

@justinliangg justinliangg deleted the i142-integrate_firebase_into_the_home_page branch January 2, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasChoong NicholasChoong NicholasChoong approved these changes

@scratchclaggy scratchclaggy scratchclaggy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate firebase into the Home page
3 participants
@justinliangg @NicholasChoong @scratchclaggy