-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LICENSE.md and expanding CONTRIBUTING.md #82
Comments
@nimit95 @piyush6348 What do you think? 😄 |
yeah happy to accept changes :) |
OK, I thought about some points for each PR: Pull RequestsWe need to identify category, algorithm and language.
License
|
Yeah, all these things seem fine, can you change in readme and contribution.md and make a pull request? |
Licensing is really important. Since everything is intended to be open, I suggest just using MIT, but if you have other ideas for it, please add it.
CONTRIBUTING.md is a bit vague in some points. It's clearly not strict on coding style patterns, perhaps by intention, but for maintainability, PR names should be strictly defined.
I suggest more specific rules for pull requests, so you can easily identify the type of PR and category, algorithm and language of the implementation.
I can suggest a structure for PRs, if you approve of this change, and then implement it on the markdown files.
The text was updated successfully, but these errors were encountered: