-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible to configure ESLint? #1933
Comments
@CompuIves I have the same question, I am getting eslint errors in Dojo sandboxes for valid syntax. Link to sandbox: link |
Yep! We definitely want to support it, I was playing a bit with making that work before. I thought the "easiest" way would be to start supporting the |
Awesome thanks @CompuIves 🎉 |
Is this on a roadmap? Is there a CodeSandbox roadmap somewhere? |
Any news about this? How to configure this or anything like that. |
Any progress here @CompuIves? I'm getting false positives with eslint |
@NickCarducci That’s not eslint doing the formatting, that’s Prettier. You should be able to put a |
I found a decent workaround so far by just disabling specific rules at the top of my files |
This doesn't work for create react app apps as far as I can see. It's literally just that one rule that I want to disable! |
Hey! This was never implemented at least until now, you will still need to do a workaround like @FrankSandqvist mentioned |
Thanks @SaraVieira , that workaround would be acceptable but it doesn't seem to be working for me: https://codesandbox.io/s/disable-unused-vars-example-syt2t?file=/src/App.tsx |
Hey In your case it needs to be these three:
because you are using TS and need to disable that too :( https://codesandbox.io/s/disable-unused-vars-example-forked-fz6ki?file=/src/App.tsx:0-80 |
Oh brilliant thank you so much! Red squigglies be gone :-) |
Nice! Sorry, we do not allow for custom config yet :( |
This issue has automatically been marked stale because there has been no activity in a while. Please leave a comment if the issue has not been resolved, or if it is not stale for any other reason. After 2 weeks, this issue will automatically be closed, unless a comment is made or the stale label is removed. |
|
Hey Thank you for bringing this to our attention, I have just added it to our internal backlog that we do want to make public but for now, it's all in notion. I will be closing but to make sure what we have in GitHub is just issues and all our feature requests are tracked in our roadmap. We will definitely make an announcement when this is done Again, thank you! |
Just in case given what I read from the discussion, getting the option to configure it for real (rather than just a pure way to disable it entirely) would be immensely helpful for me. My main goal was to reproduce / ensure I could reproduce a would-be bug with some specific plugin of eslint, and for this, to make a working codesandbox example with the behaviour shown clearly. Thank you very much for the tool and best of luck with your work on it. ❤️ |
Hello @SaraVieira 👋 Is there any update on this, do you still plan to add a possibility to use custom ESLint config? :) |
Hey @sitek94 - This is still something that we're actively exploring but there are some issues that we haven't managed to resolve just yet. If we manage to resolve them we won't be able to release this until at least next year. |
All right, thanks for information @JamesACS! Good luck with that and 🤞 we will see it one day :D |
Interested for the use cases of eslint, typescript-eslint, and angular-eslint integration in the codesandbox editor 👍 |
I wanted to demonstrate top-level I was surprised to see that adding an |
A++ 100% works |
❔ Question
Is it currently possible to configure ESLint at all? I can see that it's running, but its options don't appear in the VSCode preferences. I'm trying to find a way to change how it treats React pragma (so it doesn't consider preact's
h
to be "unused") but so far I've had no luck! I've tried to add my own.eslintrc.json
but it didn't seem to take.Link to sandbox: link
The text was updated successfully, but these errors were encountered: