Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated usage of assembleFiles API eventually causes tooManyModules #50

Open
bengotow opened this issue Mar 30, 2019 · 1 comment
Open

Comments

@bengotow
Copy link

We're using codesandboxer within docz and it runs assembleFiles over and over in a single Node process. There's a global counter in loadFiles that increments each time it's run, and after you invoke it 120 times it starts throwing { key: 'tooManyModules' }.

I think it makes sense to check that a single sandbox doesn't contain too many modules, but the count variable should probably be passed as an argument and incremented as loadFiles is called recursively so that the counter isn't global?

@Noviny
Copy link
Collaborator

Noviny commented Mar 31, 2019

This sounds absolutely correct, this shouldn't be a global.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants