Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default word regex and grave accent (`) #2981

Closed
DimitriPapadopoulos opened this issue Jul 28, 2023 · 1 comment · Fixed by #2983
Closed

Default word regex and grave accent (`) #2981

DimitriPapadopoulos opened this issue Jul 28, 2023 · 1 comment · Fixed by #2983

Comments

@DimitriPapadopoulos
Copy link
Collaborator

Why include the grave accent (`) in the default word regex?

word_regex_def = "[\\w\\-'’`]+"

This messes up Markdown checking, just for the sake of catching these two typos:

coulden`t->couldn't
woulden`t->wouldn't

These two fixes don't really make sense, we don't even catch the same typos with the apostrophe (') or acute accent (´), :

coulden't->couldn't
coulden´t->couldn't
woulden't->wouldn't
woulden´t->wouldn't
@luzpaz
Copy link
Collaborator

luzpaz commented Aug 6, 2023

CC @larsoner do you mind weighing in ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants