Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python2 support #64

Closed
larsoner opened this issue Apr 22, 2016 · 5 comments
Closed

Python2 support #64

larsoner opened this issue Apr 22, 2016 · 5 comments

Comments

@larsoner
Copy link
Member

Would the devs be interested in me adding support for Python2? I've worked on a number of packages with support for Python2 and Python3, so I don't expect it would be too bad.
@larsoner
Copy link
Member Author

(I could also take care of #63, at least via a --returncode option or so, while I'm at it)

@larsoner
Copy link
Member Author

I also kind of hoped #38 (PyPi/pip) would work out of the box, and #60 (ignore directories) would have saved me some pain, so I might try to make time for those, too, if it's welcome.

@larsoner larsoner mentioned this issue Apr 22, 2016
Closed
@lucasdemarchi
Copy link
Collaborator

@Eric89GXL all of these contributions are welcome. I'm against an option for returncode though. This should be the normal behavior, without needing an option.

@larsoner
Copy link
Member Author

Sounds good to me

@larsoner
Copy link
Member Author

Are there any unit tests I should use to test it? Or should I write some? I'm concerned about introducing regressions...

This was referenced Apr 22, 2016
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucasdemarchi @larsoner