Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no ./codespell.py #82

Closed
jwilk opened this issue Jun 10, 2016 · 18 comments
Closed

There is no ./codespell.py #82

jwilk opened this issue Jun 10, 2016 · 18 comments

Comments

@jwilk
Copy link
Contributor

jwilk commented Jun 10, 2016

README says:

Check usage with ./codespell.py -h

But there is no ./codespell.py (unless you cd into bin, in which case the command doesn't work either).

codespell.py was moved from . to bin in b400e42, but I don't understand why. The commit message is enigmatic.

@larsoner
Copy link
Member

It follows a more standard Python lib pattern to put it in bin. Really most people will / should probably now install via pip and thus just be able to do codespell.py directly

@gemal
Copy link
Contributor

gemal commented Oct 23, 2016

    copying build/scripts-3.4/codespell.py -> /home/scrutinizer/.pyenv/versions/3.4.1/bin
    changing mode of /home/scrutinizer/.pyenv/versions/3.4.1/bin/codespell.py to 775

is this normal? That I cant just run codespell.py but it seems only to be able able in /home/scrutinizer/.pyenv/versions/3.4.1/bin/codespell.py ?

@lurch
Copy link
Contributor

lurch commented Mar 15, 2017

most people will / should probably now install via pip and thus just be able to do codespell.py directly

...except now that pypi has been upgraded ( #101 ), pip will actually install the executable codespell instead of codespell.py

@larsoner
Copy link
Member

Argh, you're right. I guess we should revert to codespell.py for backward compatibility reasons

@larsoner
Copy link
Member

@lucasdemarchi do you agree we should change the name to bin/codespell.py instead of bin/codespell? I think it's necessary for backward compatibility.

@lurch
Copy link
Contributor

lurch commented Mar 15, 2017

Isn't it 'better' to have installed commands without the extension? (I assumed this change was deliberate)

@larsoner
Copy link
Member

Yeah it is better, but I'm worried about backward compatibility. For people who used to do codespell.py it won't work anymore. So I'm starting to think we should use the old name.

@anatol
Copy link
Collaborator

anatol commented Mar 15, 2017

Please keep codespell file without file extension. It has been done this way for a long time. The convention has been changed in previous release and that is why we requested reverting it back to codespell.

@larsoner
Copy link
Member

Ahh okay, thanks @anatol

@jviotti
Copy link

jviotti commented Sep 11, 2017

But the problem is that removing .py breaks the tool Windows, which relies on extensions to know how to execute a file. Could we have codespell.py for Windows, and just codespell elsewhere?

@larsoner
Copy link
Member

Should we just provide both, then?

@larsoner
Copy link
Member

Could we have codespell.py for Windows, and just codespell elsewhere?

I guess that's an option, too. I'll look and see what happens with binaries installed from other repos I work on. I know we have command-line utilities and AFAIK we don't do anything special for Windows. It's possible that they have just never worked there, I guess.

@larsoner
Copy link
Member

I guess that you can use setuptools to take care of it. This might be the best/simplest route. Someone want to give it a try?

@larsoner
Copy link
Member

I have verified locally that setuptools does indeed install a codespell.exe for Windows so just doing codespell works there with #136

@lurch
Copy link
Contributor

lurch commented Nov 16, 2017

Woohoo, great to see this issue fixed 👍 Any chance of a release on PyPi? ;)

@larsoner
Copy link
Member

Yes that's the next step, I should have time by next week

@jviotti
Copy link

jviotti commented Dec 1, 2017

Has the release been published?

@larsoner
Copy link
Member

larsoner commented Dec 1, 2017

https://pypi.python.org/pypi/codespell/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants