Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume Control not working #9

Closed
iKasu2k opened this issue Dec 26, 2021 · 4 comments · Fixed by #10
Closed

Volume Control not working #9

iKasu2k opened this issue Dec 26, 2021 · 4 comments · Fixed by #10
Labels
enhancement New feature or request

Comments

@iKasu2k
Copy link

iKasu2k commented Dec 26, 2021

Hi & Merry Christmas! This Bot is exactly what I was looking for as a middleware for a bigger project, but I ran into a
tiny tiny problem.... when trying to adjust the volume through spotify it doesn't seem to work.

Unfortunately, I'm not into rust but still went ahead and tried to rebuild the bot with initial volume
for librespot and also adjusting the volume in the enable_connect function, however, it doesn't affect the bot as well.
Volume remains constant.

Is there a way to adjust the initial volume of the bot?

@sibartel
Copy link
Contributor

Heyho Kasu,
in the last days I have made a few changes based on personal needs to aoede and among other things added a volume control via spotify. From your description, I didn't quite understand if you want to adjust the volume while listening or if you are only interested in configuring the initial volume. Nevertheless, you can take a look at my fork and especially this commit:

sibartel/aoede@7e45d7f490e9d786f8d9444415bc6c4a9f7ad816

There are still some things on my list which I want to tackle. After I implement these, I will also discuss with @codetheweb if he is interested in a pull request for some or all of my changes.

Best regards!

@codetheweb
Copy link
Owner

Yep, volume control would be nice.

@sibartel that'd be great!

Let me know when you're ready and we can discuss.

@codetheweb codetheweb added the enhancement New feature or request label Dec 26, 2021
@iKasu2k
Copy link
Author

iKasu2k commented Dec 27, 2021

@sibartel volume control via spotify was exactly what I was looking for.
I thought it would be a bit more complex to implement, thus asked if it's possible to adjust initial volume.

You both saved Christmas for me, thank you very much!

@codetheweb
Copy link
Owner

Released in v0.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants