Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem - Favorites #606

Closed
dotcfg opened this issue Mar 26, 2022 · 10 comments · Fixed by #954
Closed

Problem - Favorites #606

dotcfg opened this issue Mar 26, 2022 · 10 comments · Fixed by #954
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dotcfg
Copy link

dotcfg commented Mar 26, 2022

What if there are to many favourites to list with /favorites list? As i see there is no page system for that one. So if it would be to many the bot CANT list it

@dotcfg
Copy link
Author

dotcfg commented Mar 26, 2022

grafik
no page argument like in /queue
grafik

@Zagrthos
Copy link
Contributor

Zagrthos commented Mar 26, 2022

Can't see a limit of favorites in the building process of the Embed. So, I think it will just post all favorites in one Message Embed and because of that there is no need of a page Split.

@dotcfg
Copy link
Author

dotcfg commented Mar 26, 2022

discord has a charter limit of 2000 charters???

@dotcfg
Copy link
Author

dotcfg commented Mar 26, 2022

and why there is on queue a page system if there is no charter limit?

@Zagrthos
Copy link
Contributor

You could also try if there is a limit and let us know then, would be way easier than speculating. :)

@dotcfg
Copy link
Author

dotcfg commented Mar 27, 2022

here the proof :)

image

@dotcfg
Copy link
Author

dotcfg commented Mar 27, 2022

limited to 4096 charters. so a page system would be a fix as it is in /queue

@codetheweb
Copy link
Owner

Happy to accept a PR to fix this. I think we might be able to get around the limit by making multiple embeds instead of having to create a page system.

@codetheweb codetheweb added bug Something isn't working good first issue Good for newcomers labels Mar 27, 2022
@Codixer
Copy link

Codixer commented Aug 29, 2022

Yes and no, if you have multiple embeds the number gets boosted to 6000 characters (4096 max for each embed, 2000 for normal text). However past that you are forced to paginate. Possibly with buttons or another method.

@github-actions
Copy link

🚀 Released in Release v2.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants