Small design tweaks based on thoughtbot designers feedback #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylefiedler
force-pushed
the
kf-design-tweaks
branch
from
ffb8da5
to
4a75422
Compare
| .slats-hgroup | ||
| h5.slats-title Max number of issues you want to receive per day: | ||
| .slats-action | ||
| p #{@user.daily_issue_limit.presence || 'not set'} |
There was a problem hiding this comment.
This works but you don't need interpolation so it might make more sense as:
p= @user.daily_issue_limit.presence || 'not set'
(there's one below too)
|
Small suggestion, but looks great after tests are fixed 👍 |
kylefiedler
force-pushed
the
kf-design-tweaks
branch
from
4a75422
to
9c9ba15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.