Cache the description meta tag #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, we were doing two queries per request to get the count of users and repos to generate the description meta tag. Presumably, we don't actually care that these numbers are super up-to-date, so we can cache it up to an hour (same as the similar text in the template's h2 tag).
prathamesh-sonpatki
approved these changes
Apr 11, 2018
|
Great job, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, we were doing two queries per request to get the count of users and repos to generate the description meta tag (see screenshot below). Presumably, we don't actually care that these numbers are super up-to-date, so we can cache it up to an hour (same as the similar text in the template's h2 tag).