Fix caching #704
Merged
Fix caching #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this partial is only rendered as a collection and we are already caching it using collection caching (`cached: true`), we should not wrap the inner partial in a cache block, otherwise Rails will double read/write from/to the cache.
|
🎉🎉🎉💯💯💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed this problem recently:
When rendering the repo "cards" on the homepage, we use the collection caching feature to avoid multiple roundtrips to the cache store (the "cache read multi" in Skylight). However, when there are cache misses, we end up doing another separate read/write to the cache store per card, and then we do another write at the end from the collection caching.
You can see this in the logs as well:
This PR fixes the issue. We are working on the Rails side to make the inner
cacheblock a no-op, but since we only ever use the repo partial as part of a collection, we can avoid the problem but removing the inner cache block for now.We expect this patch to completely eliminate the "cache read" block shown in the Skylight screenshot above, and cut the "cache write" block by (roughly) half.