Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed kata still being reported as not completed in kata detail page #1683

Open
ZEDCWT opened this issue Jan 16, 2019 · 49 comments
Open
Labels
issue/not-marked-as-completed Temporary label to group issues about kata not marked as completed kind/bug

Comments

@ZEDCWT
Copy link

ZEDCWT commented Jan 16, 2019

Describe the bug

So i just completed this kata, (more exactly, i clicked submit my solution). And suddenly redirected to the solutions page as usual but seeing
20190116212400

The 4 point honor was added (39888 -> 39892), and it is both reported as completed on /{user}/completed page and /kata list page
20190116212451
20190116212501

But not on the kata detail page or trainning page
20190116212613
// I missed the screenshot for the detail page, but the button was TRAIN instead of TRAIN AGAIN IIRC

To clearify, im the only one completed it so far.
And i was not logged out during the whole process.

PS. I will not submit again before someone can investigate it.

┆Issue is synchronized with this Clickup by Unito

@FArekkusu
Copy link

Happened to me a few times as well on Beta katas exclusively. I didn't report this as the behavior of this bug is identical to #1592:

  • the user is redirected to still "closed" solutions page, and the "previous solutions" tab is absent in the trainer
  • the honor is granted, the kata is listed as completed in the user's profile, and the solution is stored in the user's profile as well.

@hobovsky
Copy link

The same happened to me with an old kata, so it's rather not an issue with betas: Explosive Sum. Solution is listed in my profile, points and progress are rewarded correctly, just kata details page does not recognize it as solved ("Train" and not "Train Again", cannot view solutions, etc).

I solved a JavaScript version, but details page for another JS kata I also finished today works fine.

@kazk kazk added kind/bug issue/not-marked-as-completed Temporary label to group issues about kata not marked as completed labels Jan 16, 2019
@hobovsky
Copy link

I wanted to add random tests to this kata. I had to solve it first, so I submitted my Java solution, passed all the tests, and... solution is recorded, it is recognized by my profile, it is recognized by he kata as far as I can tell (all related counters increased), just kata page does not seem to acknowledge the fact. Cannot access solutions, cannot see test cases, cannot translate nor fork it.
Additionally, the issue with kata from previous post still persists after all these days, so I think it's not temporary/caching/timing thing.

@FArekkusu
Copy link

FArekkusu commented Jan 22, 2019

Unobvious work-around: re-submit your solution. You can also consider those 4 additional honor points for "completing the kata the 2nd time" as a bonus for having to deal with the DB issues ;)


At least that's the only way to gain access to the solutions page, and get the ability to assess kata rank and quality. What still remains unknown when this bug occurs is:

  • whether you can see spoiler comments after incorrectly registered completion
  • whether the + ADD NEW button is available when choosing the kata language

Although, I suspect these are not available as well, considering that only the user's profile "remembers" the kata completion, but not the kata itself.

@beginnerJavaCoder
Copy link

I have the same trouble twice for today. I pushed my solutions 2 times, and system adds me honor for each push. It isn't problem of beta katas. I don't think this way is fair. But i also don't know how to see my solution in solutions' page and to vote up for solved kata.
image
image

@kazk
Copy link
Member

kazk commented Jan 22, 2019

Sorry about this. I haven't spent much time on this yet.
It's been happening since 2016 (#311) but getting extra honor points might be new.

@FArekkusu
Copy link

but getting extra honor points might be new

I mean you get kata-completion honor for both solution submissions, as according to the DB you've solved 2 different katas (if I iunderstood the situation correctly from your reply in #1592).

@kazk kazk added the issue/solution-not-shown Temporary label to view all issues about this. label Jan 22, 2019
@hobovsky
Copy link

Exactly like @FArekkusu says, everything is counted once per completion: I was able to vote twice, I got honor for solution, satisfaction and difficulty rating twice, I do not know about my rank progress, but I will be glad to test it with some purple :)

@FArekkusu
Copy link

What still remains unknown when this bug occurs is:

  • whether you can see spoiler comments after incorrectly registered completion
  • whether the + ADD NEW button is available when choosing the kata language

Confirmed, when this bug occurs, you also can't write translations and see spoiler comments.

@eb110
Copy link

eb110 commented Jan 23, 2019

I have the same experience for following kata:
image
image
image

@eb110
Copy link

eb110 commented Jan 23, 2019

Same here:
image
I've had to submit twice for java and javastring solutions

@eb110
Copy link

eb110 commented Jan 23, 2019

For
image
i didn't have to submit twice for javascript

@hobovsky
Copy link

Small update on this one:

After clicking "Refactor" link under solution for such incorrectly registered kata, I get invalid editor screen, with blank language fields:

cw error

After completing such kata one more time, my overall rank score, language rank score, and totalCompleted counter are increased just as if I solved it the first time.

If I were to guess, it seems as if registering a solution was done in two separate code branches or maybe even transactions: one for user profile->solution, and one for kata->solution, and the second one for some reason either is not performed, or fails more and more often. Buy yeah, just a guess.

Feel free to delete my duplicated solutions, or all solutions for affected kata - I can always redo them.

@kazk
Copy link
Member

kazk commented Jan 23, 2019

@FArekkusu you're right. I don't think it's anything new. (There's so many issues that I get mixed up.) It might be happening more frequently though because of one change in the updated database driver.


I figured out the causes of these symptoms, but I'm still trying to find why/how it reaches that point.

  • Completed kata not marked as complete
  • Get solution withheld after submit final
    • Same as above
  • Solution not listed in kata's solution page
    • The solution failed to be grouped (including being in its own group)
    • I fixed a major data integrity issue yesterday that was causing this to happen very frequently so this shouldn't happen as often as before
  • Solution on the profile's solution page is missing the link for "Discuss"
    • same reason as not listed under solutions
  • Clicking "Refactor" for incorrect one results in empty editor
    • This is failing to look up the solution to be refactored because of multiple records
  • Work in progress solution is gone
    • Duplicate records exists and different document was loaded when reopening the trainer

So the main cause of all of these is having multiple records for a user with a kata. And it's been like this for few years now 🤦‍♂️

After seeing all the data integrity issues, it's kind of amazing that it's still (mostly) working.

@Len512
Copy link

Len512 commented Feb 11, 2019

Not exactly the same issue, but I think it might be relevant:
I have completed a kata, voted on it, it is in my profile under 'Solutions', I can see my solution under the solutions tab in the kata page, but it still shows up in my filtered search among the 'kata I have not completed' (1st pic).

screen shot 2019-02-11 at 10 24 47
screen shot 2019-02-11 at 10 27 23
screen shot 2019-02-11 at 10 29 32

@Voileexperiments
Copy link

Voileexperiments commented Mar 15, 2019

This is happening for me too for this kata. I tried the kata back when it was beta and just completed it, however solutions are not unlocked.

It seems that when this happens, the saved solution associated with the kata is gone and the kata won't be displayed as solved.

However! I submitted my solution again with a very old session that was left open for an entire week, and it worked for some reasons.

@hobovsky
Copy link

hobovsky commented Mar 15, 2019

It's not that solution is completely gone, usually there is some trace that it was accepted. For me, it's usually "Kata" tab in my profile - they always appear there for me, although on kata page I get no "train again" and solutions are hidden.

image

Yesterday hit the problem twice, and it happens to be more and more common. Or, at least, not as uncommon to be called just a 'glitch'. I noticed that incorrectly recorded solutions miss "Discuss" link in Profile/Solutions view, and there's quite a lot of these - I'd estimate it as 10% of all solutions do not have the link, so they are probably affected by this bug (and I have a scraper for these, so I can count exactly if someone wants). Quite a few.

image

My question would be, when such situation is encountered, what should we do and what should not we do? After fix is done, will invalid solutions disappear or be fixed? Do we need to have at least one correctly recorded solution to make everything ok after the fix, or the incorrect ones will be fixed?

EDIT: So I went to my solutions page, scrolled to the bottom so everything loads, and counted:

Search "discuss" (617 hits in 1 file)
Search "refactor" (716 hits in 1 file)

I have 99 problems, it seems.

@Voileexperiments
Copy link

Voileexperiments commented Mar 15, 2019

Indeed I'm seeing both of them:

image

The problem is, the belong to the same project, but with a different session. The top one is

https://www.codewars.com/kata/projects/5c879f967aabc44ea5d7eefe/agda/session/5c8b5abba99b9c000d07d828

which entire content is visible to me when I do a post request to it, while the bottom is

https://www.codewars.com/kata/projects/5c879f967aabc44ea5d7eefe/agda/session/5c879f985253b04f7f198347

which doesn't even return 403, it returns 404. So the session has completely disintegrated or something.

@Voileexperiments
Copy link

@kazk I recall a long time ago when there was a preview link to CW with the project interface (like the one in qualified.io?) that has the entire directory listing and several code editor blocks. Does it have to do with this?

@hobovsky
Copy link

Interesting follow-up: when issue creates two sets of solutions, I can choose into which set I submit solutions from now on. So when I accidentally got two Java solutions for one kata, I was able to submit Haskell solution twice too, once for each "set":

image

It kinda sucks, because all numbers get really skewed then - I get honor, total progress and language progress counted as many times as there are "sets" :(

@jtlindsey
Copy link

The issue happen to me for first time today. The page was also loading really slow while all my other sites were loading fast. I reloaded the page and submitted solution again.

@preactive
Copy link

preactive commented Aug 6, 2019

@kazk without knowing about the data sensitivity nature of the problem... but thought about dropping something like bounties for support in fixing some bugs on the platform like this one?

Edit: the platform has some very bright people and to see if people want to engage with helping out if it does not break legal or otherwise established agreements in regards to sensitive data.

@0legRadchenko
Copy link

image
I clicked on 'submit solution' and I got an error such as: "You need to complete this task in order to check solutions of other people" then I returned back and submitted my code again and it worked fine but it gave me an extra honor because I repeated this actions 3 times with another submitted solutions (at the third time I have completed this task with more clear code) and then I checked my profile and I have amazed because now I got 100 honors instead of ~30-40 for JUST ONE KATA.

kata - https://www.codewars.com/kata/range-extraction/python
my profile - https://www.codewars.com/users/OlegRadchenko

@suryasiriki4

This comment has been minimized.

@silvercodemode

This comment has been minimized.

@kazk

This comment has been minimized.

@kazk
Copy link
Member

kazk commented Aug 27, 2019

The frequency of this issue should have dropped significantly after the recent database upgrade. Codewars was using super old (and infamous) versions of MongoDB and had lots of weird issues like not finding documents in the database which can cause duplicates like these. The number of errors around solutions dropped significantly so I'm hoping this was mostly fixed as well.

To completely prevent this from happening in the future, I need to analyze the affected data, fix them by somehow merging them, and then add unique index. I don't have any timelines for that yet, but I need to know if this is still happening or not first. So please let me know if this happens again. No screenshots are necessary.

@aliasfoxkde
Copy link

Whatever is going on, the problem initially and randomly would not allow me to see Kata solutions (sometimes old ones and sometimes new ones after completion, even 8 kyu challenges with an access warning). Now it's extended to being all the time, on multiple browsers (regardless of logging in/out again which would resolve the "issue" in the past) and now I get an "Unauthorized" error when trying to leave a comment. I used to use CodeWars daily but now use it rarely, but started up again to complete Kata's with a friend who is learning to code.

Kata_Bug_Error

@Blind4Basics
Copy link

@aliasfoxkde what's your CW's username?

@aliasfoxkde
Copy link

It's aliasfox

@Blind4Basics
Copy link

Blind4Basics commented Sep 18, 2021

Your account has been restricted because evidences of plagiarism have been found (a lot).

@aliasfoxkde
Copy link

That's interesting because I've solved every Kata first and then have gone back to refactor solutions more cleverly, often more condensed and shorter, which is what CodeWars seems to lend toward (more clever than maintainable code). It doesn't break any rules and being most things are solved the same way, it is also hardly plagiarism . But if that's the system, I guess it is what it is. I also never received a message and still get daily Kata updates. That sounds like a bug to me. Thanks.

@Blind4Basics
Copy link

[...] It doesn't break any rules

Refactoring, no it doesn't. But that's not the reason why your account got restricted.

Sorry, but when looking at your solutions data, it's absolutely obvious you didn't solve the hard kata "on your own" (nothing in 4 kyu or harder).

I also never received a message

Effectively, that isn't implemented so far. Dunno if that will be done.

The kata updates aren't related to the account restriction, so no bug there.

@aliasfoxkde
Copy link

I read through the "Code of Conduct" and "Privacy Policy" and I didn't explicitly violate them, but I see looking at your account on GitHub that you did: "Please do not post your solutions on Github.". I do have another account with have more progress, but I digress. I don't mean disrespect, but if you're going to hold someone accountable, hold them (including yourself) to a standard.

You might need a refresher, so here's some reading material:

Links:
https://docs.codewars.com/community/rules/
https://www.codewars.com/about/privacy

@Blind4Basics
Copy link

I didn't explicitly violate them

Completing kata using solutions of other users is not "honorable" in any way...

(including yourself)

'beg you pardon??

@ZdraviiSmisl

This comment was marked as off-topic.

@hobovsky

This comment was marked as off-topic.

@ZdraviiSmisl

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/not-marked-as-completed Temporary label to group issues about kata not marked as completed kind/bug
Projects
None yet
Development

No branches or pull requests