Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Lean Support out of Beta #2134

Closed
DonaldKellett opened this issue May 13, 2020 · 12 comments
Closed

Move Lean Support out of Beta #2134

DonaldKellett opened this issue May 13, 2020 · 12 comments

Comments

@DonaldKellett
Copy link
Member

So now we have 76 Lean kata in total (compared to 79 in Coq as reference), 50 of which have been approved and no major issues with the current setup thus far. What do you say about moving Lean out of Beta and officially declaring it as a stable supported language on Codewars?


👍 reaction may help

@monadius
Copy link

One thing which need to be done before moving Lean out of Beta is to update the mathlib version and see how easy it will be to fix existing kata. I don't know about Lean itself, but mathlib should be periodically updated.

@DonaldKellett
Copy link
Member Author

AFAIK mathlib commits are tightly coupled with the Lean version so we will probably have to update our Lean version as well. I'll ask the community over at Zulip if having a slightly outdated Lean + mathlib (v3.7.2 compared to the current v3.11.x) is an issue, and if so, we can request for the Lean version (and the corresponding mathlib) to be updated.

@monadius
Copy link

Lean 3.11 with the updated mathlib is considerably slower than Lean 3.7.2. Because of this, I am not able to update the Lean version of my Chebyshev kata. I created an (almost) empty kumite which demonstrates that just importing analysis.special_functions.trigonometric is enough to get a timeout in Lean 3.11.

@kazk
Copy link
Member

kazk commented May 15, 2020

:(
I made the container image exactly the same way so I believe Lean 3.11.0 and/or this mathlib version is much slower for some things. Currently 65/81 kata have 3.11.0 enabled (was compatible and also didn't timeout).

If I remember correctly, Lean 3.7 was slower than 3.5 and 3.6 as well (which was also slightly slower than 3.4) when I was experimenting (codewars/codewars-runner-cli#773). I'm not increasing the time limit every time it gets slower.

@DonaldKellett
Copy link
Member Author

For Lean-only kata that cannot be updated due to timeouts, perhaps we should just retire them? Not sure how to handle those with Coq versions as well though (IIRC it cannot just be removed due to database issues?) ...

@monadius
Copy link

Let's just wait. If understand this Zulip discussion correctly, long import times is a known issue and it may be fixed in future Lean releases. Although it is also true that mathlib itself is growing and timeouts in future are still possible.

@DonaldKellett
Copy link
Member Author

@kazk All except Real Chebyshev have been updated to 3.11.0.

@kazk
Copy link
Member

kazk commented May 18, 2020

We can keep 3.7.2 for now. Hopefully, the next update fixes the problem.
I'll close when I deploy the change to move Lean out of beta.

@kazk
Copy link
Member

kazk commented May 19, 2020

Deployed

@kazk kazk closed this as completed May 19, 2020
@sainiboey
Copy link

what is kata

@DonaldKellett
Copy link
Member Author

Thanks for moving Lean out of Beta, I've updated the Wiki to reflect the change. By the way, it seems that the main page still says that Lean is in Beta?

螢幕截圖 2020-05-20 12 37 21

@kazk
Copy link
Member

kazk commented May 20, 2020

The cache wasn't invalidated. It should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants