New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate - count characters in string #110
Comments
Keep 3rd Retire 2nd (due to being same rank as 3. & dup of 3.) I think among 1st, 4th, 5th, we can choose one to keep but not sure how to decide for now... (IMO the rank should be same as 3rd. since those 3 asked for additional tasks such as filtering, sorting, convert to array of arrays etc., but 5th has the highest number of languages and completions thoo it's 7kyu...) EDIT: Due to 5th having an interesting output type and has highest completion, keep it!!! |
Just a note to say about 5 (I've translated recently to D): I think the difference of returning an ordeedr list of tuples make the task sufficiently different from others. For a basic kata, I think this is an interesting and pertinent variation that worths to be conserved. I think it would be good to conserve this one and probably another expecting a hash, I'll examine it better later and will vote in consequence. |
Keep number 5, retire the rest. |
Backstory of no. 5: The reason for creating the kata was to show a pattern (aka clever hack) which was relevant before 3.6. This is way easier to solve now than it was at the time it was published due the new I also agree with @akar-0 that it's different enough from the others to keep it. However, is not that different as it was at the time of creation. IMO this type of kata is 7kyu. |
Just to be clear, I am aware how handling appearance order can be an additional challenge, and it actually still is, in many languages. Order of maps and dictionaries is often an implementation detail, and maintaining it can be challenging in languages other than Python. Reviewers should take this into account while choosing candidates for deduplication. If the requirement of the order is properly enforced and tested (i.e. not just with |
vote for keep 5, retire the others |
I would keep 3 and 5, and retire the rest. |
Everyone seems to agree to keep 5., so it will stay. |
In Python, most of the kata can be solved with a mere
from collections import Counter as solution
.Counter
Counter
Counter
Languages:
A - approved translation
P - pending translation
Conclusion
Filling gaps
The text was updated successfully, but these errors were encountered: