Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate - Count Words #131

Closed
hobovsky opened this issue Aug 20, 2022 · 5 comments
Closed

Deduplicate - Count Words #131

hobovsky opened this issue Aug 20, 2022 · 5 comments
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata

Comments

@hobovsky
Copy link
Contributor

hobovsky commented Aug 20, 2022

From #39

  1. Count words
  • 6 kyu
  • 85% with ~600 completions
  • Any non-letter is a non-word character (i.e. a separator). Some words from a predetermined list should not be counted.
  • no pending issues
  • 2 approved languages, 2 pending translations
  • Published Feb 2016, author active
  1. Count words
  • 8kyu
  • Separators are whitespace characters, but "whitespace" is defined really bad, and not tested well.
  • 82% with 6.7k completions
  • no pending issues
  • 1 approved language, 4 pending translations, C# exclusive
  • Published Apr 2016, author inactive

Conclusion

The kata are not duplicates and both will be kept.

@hobovsky
Copy link
Contributor Author

I think that however easy/boring/dull both kata are, they are not similar enough to be considered duplicates and I would not remove any as a duplicate of another.
However, 2. is in not a really good shape and deserves retirement just because of this. Description is confusing, does not explain what "whitespace" is, tests do not check for said whitespace except two characters.

I vote to keep 1., and fix or retire 2. due to bad quality.

@ejini6969
Copy link

I agree with hobs, the rank for 2 is also abit inappropriate

@Kacarott
Copy link

Keep both, I think the premise of 2 makes a worthwhile 8kyu kata if the description (and potentially tests?) were rewritten.

@KayleighWasTaken
Copy link

If we're keeping just one then 1 is better, but both are different tasks. 2 needs a description/tests rewrite.

@akar-0
Copy link

akar-0 commented Aug 24, 2022

Keep both an fix 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata
Projects
Development

No branches or pull requests

5 participants