Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate - Morse decoder #157

Closed
1 task done
hobovsky opened this issue Oct 12, 2022 · 2 comments
Closed
1 task done

Deduplicate - Morse decoder #157

hobovsky opened this issue Oct 12, 2022 · 2 comments
Assignees
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata

Comments

@hobovsky
Copy link
Contributor

hobovsky commented Oct 12, 2022

  1. Decode Morse
  • 6 kyu
  • 88% with ~1k completions
  • 3 pending issues, 2 about being a duplicate
  • 3 languages
  • Published Jan 2015, author inactive
  1. Decode the Morse code
  • 6 kyu
  • 89% with 88k completions
  • 2 pending issues
  • 23 languages, 2 pending issues
  • Published Jan 2015, author active

Conclusion

@hobovsky
Copy link
Contributor Author

The kata are almost exact duplicates, solutions differ by a single space and a name of a preloaded variable.

I vote to keep 2. as more complete, and retire 1. as duplicate.

@benjaminzwhite
Copy link

benjaminzwhite commented Oct 15, 2022

I voted to keep 2, but noticed that in Python there are no random tests whatsoever.

updates:

  • Python fork with random tests and new test framework approved by B4B, issue closed on kata page.
  • I removed "Decode the Morse Code" from main list of kata to update.

I therefore created a fork, which adds random tests and updates to new Python test framework:

Link to Issue raised on kata discourse page

Direct link to Python fork with random tests and updated test framework

Please update the main Python list if you approve the fork, or let me know in the kata discourse and I'll do it:

https://github.com/codewars/content-issues/wiki/List-of-Python-Kata-to-Update

Please check for the Python fork that I have implemented the "back-compatibility" correctly where I first try to import the solution under the old naming convention decodeMorse before importing decode_morse - it's the first kata I've updated where there is such a requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata
Projects
Development

No branches or pull requests

3 participants