Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arel for Ruby 3.0.0 #155

Open
epeleh opened this issue Nov 7, 2021 · 3 comments
Open

Add arel for Ruby 3.0.0 #155

epeleh opened this issue Nov 7, 2021 · 3 comments

Comments

@epeleh
Copy link

epeleh commented Nov 7, 2021

Please complete the following information about the package:

Following are optional, but will help us consider adding:

Recently I added a new Kata and it works fine on Ruby 2.5.0 but fails validation on Ruby 3.0.0 due to the missing gems. I consider that ideally, all the gems available in Ruby 2.5.0 should be available in Ruby 3.0.0 as well.

  • Arel is part of Rails - it might be better to add whole Rails, not just Arel. At least, in my opinion, it is worth adding activesupport gem - it can sometimes be useful for solving tasks

  • method_source - might be helpful for writing tests that validate a solution code

Both of these gems are already available in Ruby 2.5.0.


👍 reaction might help to get this request prioritized.

@FArekkusu
Copy link

FArekkusu commented Nov 7, 2021

method_source - might be helpful for writing tests that validate a solution code

You can read the solution file instead.

@epeleh
Copy link
Author

epeleh commented Nov 8, 2021

You can read the solution file instead.

Yep, you're right!

We can get a solution code by running:

File.read(RUBY_VERSION.to_i >= 3 ? 'lib/solution.rb' : 'solution.txt')

In our case, it should work even better than method(:solution).source. I updated the Kata - it no longer needs the method_source gem

Thanks! 👍

@kazk
Copy link
Member

kazk commented Nov 8, 2021

You can read /workspace/solution.txt in all languages and versions.

I consider that ideally, all the gems available in Ruby 2.5.0 should be available in Ruby 3.0.0 as well.

I strongly disagree. Your list includes transitive dependencies, which we never claimed they're supported.

@kazk kazk changed the title Add arel & method_source gems for Ruby 3.0.0 Add arel for Ruby 3.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

3 participants