New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for EditorJS nesting #1055
Fix for EditorJS nesting #1055
Conversation
03975f5
to
c52eda9
Compare
I saw the proposal that make Editor.js nestable, some times. So, I developed the plugin to nest Editor.js instance. But, tiny fixes were needed to event handlers, so I opened this PR. |
This PR may be not needed by using Shadow DOM or iframe in my plugin. |
@hata6502 Unfortunately your links run into a 404. I would be very pleased if you can fix this :) Greetings |
Sorry, I couldn't find another solution. |
@Xerathron |
Hi there I'm closing PR and related issues for now. |
@gohabereg |
Editor.js can be nested by using iframe! https://github.com/hata6502/editorjs-inline |
@hata6502 do you think it is possible to apply those fixes without changing editorjs itself? like through the api or class inheritance or something? i really need this functionality, and everything would be fine if your fixes were applied. but i certainly can not run a modified editorjs version... |
@miko007 You can try using it:
|
thank you for your suggestion. i certainly could use your repo, but i imagine you do not fancy maintaining it, just for the sake of one guy using it. i am not in need of an efficient solution, but one that works. On the other hand, if those changes do not interfere with regular For my usecase this is the ideal solution, as all other solutions just do html/css trickery for achieving columns, but i need a true nested editor with nested blocks, because i do not use editorjs to generate HTML but PDFs, where flexbox etc. is useless. With your changes i am able to achieve all goals for the project. Nevertheless it would be nice to use the upstream version of editorjs. |
editor-js-grid is revived as editorjs-layout! |
By nesting Editor.js, it can design layouts more flexibly.
I fixed some event handlers to nest Editor.js.
Demo
https://codesandbox.io/s/editor-js-grid-nest-ro2uz?fontsize=14&hidenavigation=1&theme=dark