Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block tunes as a popover #2091

Merged
merged 83 commits into from Nov 3, 2022
Merged

Block tunes as a popover #2091

merged 83 commits into from Nov 3, 2022

Conversation

TatianaFomina
Copy link
Contributor

  • Updates block tunes to use popover component. As a temporary solution, non-default block tunes are rendered as before and inserted to special area inside the popover.
  • New getter blockSettings (naming could be discussed) is added to tunes interface. It allows to configure the way tune is displayed in the popover.

image

src/components/block-tunes/block-tune-delete.ts Outdated Show resolved Hide resolved
src/components/block/index.ts Outdated Show resolved Hide resolved
src/components/modules/toolbar/blockSettings.ts Outdated Show resolved Hide resolved
src/components/utils/popover.ts Outdated Show resolved Hide resolved
src/components/block/index.ts Outdated Show resolved Hide resolved
src/components/block-tunes/block-tune-delete.ts Outdated Show resolved Hide resolved
src/components/block/index.ts Outdated Show resolved Hide resolved
src/components/block/index.ts Outdated Show resolved Hide resolved
src/components/block/index.ts Outdated Show resolved Hide resolved
src/components/modules/toolbar/blockSettings.ts Outdated Show resolved Hide resolved
src/components/utils/popover.ts Outdated Show resolved Hide resolved
src/components/utils/popover.ts Outdated Show resolved Hide resolved
src/components/utils/popover.ts Outdated Show resolved Hide resolved
types/block-tunes/block-tune.d.ts Outdated Show resolved Hide resolved
Copy link
Member

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@neSpecc
Copy link
Member

neSpecc commented Nov 2, 2022

Write change logs, please

@@ -1,7 +1,10 @@
import { fromCallback } from 'cypress/types/bluebird';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually a problem as it makes the cypress dependency, and causing the following errors for the apps

Error: node_modules/@editorjs/editorjs/types/configs/index.d.ts:1:30 - error TS2307: Cannot find module 'cypress/types/bluebird' or its corresponding type declarations.

1 import { fromCallback } from 'cypress/types/bluebird';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants