New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block tunes as a popover #2091
Merged
Merged
Block tunes as a popover #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TatianaFomina
requested review from
neSpecc,
gohabereg and
ilyamore88
as code owners
July 5, 2022 16:45
neSpecc
reviewed
Jul 6, 2022
neSpecc
requested changes
Jul 25, 2022
neSpecc
reviewed
Jul 28, 2022
neSpecc
reviewed
Jul 28, 2022
neSpecc
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write change logs, please |
gohabereg
approved these changes
Nov 2, 2022
This was referenced Nov 4, 2022
This was referenced Nov 14, 2022
DenysVuika
reviewed
Jan 23, 2023
@@ -1,7 +1,10 @@ | |||
import { fromCallback } from 'cypress/types/bluebird'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is actually a problem as it makes the cypress dependency, and causing the following errors for the apps
Error: node_modules/@editorjs/editorjs/types/configs/index.d.ts:1:30 - error TS2307: Cannot find module 'cypress/types/bluebird' or its corresponding type declarations.
1 import { fromCallback } from 'cypress/types/bluebird';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blockSettings
(naming could be discussed) is added to tunes interface. It allows to configure the way tune is displayed in the popover.