Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Serious Issue Tab on Input opens the Menu after Update to v2.26.4 #2228

Closed
khanakia opened this issue Dec 23, 2022 · 4 comments
Closed
Labels

Comments

@khanakia
Copy link

Describe a bug.

Steps to reproduce:

  1. Go to https://editorjs.io/
  2. Click on Caption Input on Image
  3. Press Tab it is opening the Menu

Expected behavior: It should not open the menu

Screenshots:

Screen.Recording.2022-12-23.at.7.55.22.PM.mov

Device, Browser, OS: Chrome

Editor.js version: v2.26.4

Plugins you use with their versions:

@khanakia khanakia added the bug label Dec 23, 2022
@khanakia
Copy link
Author

@neSpecc It will affect production for many users.

We should patch it on a priority basis.

I hope you can understand.

@gkovats
Copy link

gkovats commented Feb 13, 2023

Is this a bug? It seems like tab has always navigated to the tune / toolbar. Maybe missing previous behavior.

@khanakia
Copy link
Author

khanakia commented Feb 13, 2023

Not sure but I fixed it by adding custom keydown code and also there seem to be lots of bug with editor.js already.

  rootNode.addEventListener('keydown', (event) => {
      switch (event.code) {
        case 'Tab':
          this.tabHandler(event);
          break;
      }
    });

PS: If you just started using editor.js I would prefer to consider using https://lexical.dev/ that seems promising and also have active community support

@gkovats
Copy link

gkovats commented Feb 13, 2023

Thanks for the recommendation, sir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants