Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for i18n #751

Closed
matheusgrieger opened this issue Apr 30, 2019 · 15 comments
Closed

Support for i18n #751

matheusgrieger opened this issue Apr 30, 2019 · 15 comments
Assignees

Comments

@matheusgrieger
Copy link

I'm trying to translate the editor tooltips and names to Portuguese, but the docs don't specify a way to do that, and in fact, it doesn't seem possible at the moment.

Can this be done?

@realmike33
Copy link

Is it, you'll have to write the code for it 💃

@matheusgrieger
Copy link
Author

Is that a "not available, needs contribution"? 😆

I'll see what I can do to help and add this feature.

@neSpecc
Copy link
Member

neSpecc commented May 7, 2019

@matheusgrieger for now you can specify the title and icon with the toolbox property of Editor Config like this:

 const editor = new EditorJS({
  tools: {
    image: {
      class: ImageTool,
      toolbox: {
        icon: '<svg>my icon code</svg>',
        title: 'My Tool Title'
      }
    }
  }
});

We will describe this moment at the docs more carefully. Also, we will think about full localisation of all UI texts.

@alxlion
Copy link

alxlion commented Dec 26, 2019

Is someone in charge of i18n for editor.js ?

There is some hardcoded value:

tooltipContent.appendChild(document.createTextNode('Add'));

So it's impossible to translate.

@t-itzel
Copy link

t-itzel commented Jan 21, 2020

@neSpecc

We will describe this moment at the docs more carefully. Also, we will think about full localisation of all UI texts.

Any progress here? I like this editor and want to integrate it into a VueJS application but I need the editor to be translated to german.

Worst case scenario would be to "translate" everything manually using

tools: {
  image: {
    class: ImageTool,
    toolbox: {
      title: '<<<TRANSLATION>>>'
    }
  },
  ...
}

even though, documentation is sparse when it comes to details about where to retrieve reference to be used in e.g. class: ImageTool from. I need some sort of import statement.

@neSpecc
Copy link
Member

neSpecc commented Jan 21, 2020

@t-itzel estimated 1-2 months. If you can contribute, it would be great and we would release it faster.

@t-itzel
Copy link

t-itzel commented Jan 26, 2020

@t-itzel estimated 1-2 months. If you can contribute, it would be great and we would release it faster.

alright, thanks. Sorry but I can't manage to contribute right now.

@blindibrasil
Copy link

How is the translation process going?
I would like to know if this support already exists, or if you are still planning to have it inserted in the next updates?
When released, I will be on hand to help with the translation into my language (PT-BR).
Thanks.

@neSpecc neSpecc mentioned this issue Apr 8, 2020
@neSpecc neSpecc self-assigned this Apr 8, 2020
@glauberm
Copy link

@neSpecc anything I could do to help with the i18n?

@neSpecc
Copy link
Member

neSpecc commented Apr 19, 2020

@glauberm This task turned out to be more complex architecturally, so I've started experimenting with it by myself. If you have a desire, we can suggest you participate in other issues. Or at least in translation, when the API will be released.

@glauberm
Copy link

@neSpecc Thanks, I'll do that

@neSpecc
Copy link
Member

neSpecc commented Apr 22, 2020

Will be shipped with 2.18 release

@vincentdesmares
Copy link

@neSpecc Great news! I will try to help too. We just need the general guidelines on how the plugins should behave.

Also there are many small notifications to take in account (ex: the image plugin).

@ycs77
Copy link

ycs77 commented May 28, 2020

I push a PR #1170 added i18n files feature 😄
Allow everyone to contribute language files. (But need to this PR merged...)

@neSpecc
Copy link
Member

neSpecc commented Jun 17, 2020

Resolved by #1181
See https://editorjs.io/i18n

@neSpecc neSpecc closed this as completed Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants