Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate simplifying the Converter interface. #4

Open
peterhuffer opened this issue Jan 30, 2018 · 1 comment
Open

Investigate simplifying the Converter interface. #4

peterhuffer opened this issue Jan 30, 2018 · 1 comment

Comments

@peterhuffer
Copy link
Collaborator

Determine whether the Converter interface would be more friendly to use if the available methods, fromAlpha2, fromAlpha3, and fromNumeric were simplified to a method that takes a country code's format value and the from and to standards. For example, Converter.fromFormatValue(String formatValue, Standard from, Standard to).

@rymach
Copy link
Contributor

rymach commented May 9, 2018

Also, it isn't obvious to users that although the converter interface will allow converting within the same standard, it won't actually work unless there is an entry in mappings.csv.

It may be worth ensuring conversion from alpha2 to alpha3 (or the opposite) within a standard also works through this interface instead of requiring users to traverse getStandardEntries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants