Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users can suggest tags with spaces (but the suggestion can't be approved) #764

Closed
Trilarion opened this issue Jan 22, 2022 · 0 comments · Fixed by #1136
Closed

Users can suggest tags with spaces (but the suggestion can't be approved) #764

Trilarion opened this issue Jan 22, 2022 · 0 comments · Fixed by #1136
Assignees
@Taeir
Labels
area: html/css/js Changes to front-end code complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. priority: medium type: bug Something isn't working

Comments

@Trilarion
Copy link
Contributor

Describe the bug

See https://meta.codidact.com/posts/285658 A user suggested adding the tag "American English". Due to it having a space, a reviewer is unable to approve the edit.

To Reproduce

Suggest an edit with a tag with spaces.

Expected behavior

The server should refuse the suggested edit the same way it's refusing edits or posts.

The client should forbid tags with spaces already on the client side before one clicks on posting.
@cellio cellio added area: html/css/js Changes to front-end code complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. priority: medium type: bug Something isn't working labels Jan 23, 2022
@MoshiKoi MoshiKoi mentioned this issue Jan 23, 2022
Closed
@Taeir Taeir self-assigned this Jul 21, 2023
@Taeir Taeir mentioned this issue Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Taeir Taeir

Labels
area: html/css/js Changes to front-end code complexity: unassessed Needs further developer investigation before complexity/feasibility can be determined. priority: medium type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add post validations also to suggested edits (301, 764, 765) eip-ewi/qpixel
3 participants
@Taeir @cellio @Trilarion