Skip to content
This repository has been archived by the owner on Aug 29, 2022. It is now read-only.

Digital Root Added #654

Merged
merged 7 commits into from May 24, 2022
Merged

Digital Root Added #654

merged 7 commits into from May 24, 2022

Conversation

us3r64bit
Copy link
Contributor

@us3r64bit us3r64bit commented May 23, 2022

Why:

Closes #664

Closes #665

Closes #668

What's being changed:

I've added Digital Root Folder which have digital_root.c,digital_root.cpp and digital_root.py.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@us3r64bit us3r64bit requested review from a team and harshraj8843 and removed request for a team May 23, 2022 18:57
@github-actions
Copy link
Contributor

💖 Thanks for opening this pull request! 💖

This PR will be reviewed and merged shortly. In the meantime, please check out the contributing guidelines.

@harshraj8843
Copy link
Collaborator

Hey @arth2002

Thanks for contributing to this project 😃

This PR will be reviewed and merged shortly

@harshraj8843 harshraj8843 added the triage Waiting for review label May 24, 2022
@us3r64bit
Copy link
Contributor Author

Hey @arth2002

Thanks for contributing to this project smiley

This PR will be reviewed and merged shortly

@harshraj8843 hey bro what to do next?
and what is the meaning of awaiting triage?

@harshraj8843
Copy link
Collaborator

@harshraj8843 hey bro what to do next? and what is the meaning of awaiting triage?

Hey @arth2002

This PR will be reviewed soon

The issue for this PR is not yet available, so first the issue will be raised then only it can be merged

@us3r64bit
Copy link
Contributor Author

@harshraj8843
so until someone raises the issue nothing can be done?
what if I raise issue?

@harshraj8843
Copy link
Collaborator

@harshraj8843 so until someone raises the issue nothing can be done? what if I raise issue?

I am raising issue for this 👍🏻

@us3r64bit
Copy link
Contributor Author

@harshraj8843 Thank you

@harshraj8843
Copy link
Collaborator

Hey @arth2002

Please move files from programme/Digital Root/ to programme/digital-root/ folder

Thanks 👍🏻

@harshraj8843 harshraj8843 added programme Programme related topics C C Programming Python Python related topics C++ C++ related topics and removed triage Waiting for review labels May 24, 2022
@us3r64bit
Copy link
Contributor Author

@harshraj8843 Done

Copy link
Collaborator

@harshraj8843 harshraj8843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@harshraj8843 harshraj8843 merged commit a12bb06 into codinasion-archive:master May 24, 2022
@welcome
Copy link

welcome bot commented May 24, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@github-actions
Copy link
Contributor

Thanks very much for contributing!

Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Support this project by giving it a star ⭐.

Join Our Community

If you're looking for your next contribution, check out our help wanted issues

@us3r64bit
Copy link
Contributor Author

Hey @harshraj8843
I have one doubt, why my name is not showing in the contributers section?

@harshraj8843
Copy link
Collaborator

Hey @arth2002

No idea about homepage contributors exactly

But its showing in file contributors

Screenshot from 2022-05-25 13-18-05

Maybe this will fix it

@us3r64bit
Copy link
Contributor Author

Thanks
it is showing in github mobile app

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C C Programming C++ C++ related topics programme Programme related topics Python Python related topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Digital Root Digital Root Digital Root
2 participants