Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Download Limit in Settings #217

Closed
aggarwalpulkit596 opened this issue May 23, 2019 · 14 comments · Fixed by #260
Closed

Add Download Limit in Settings #217

aggarwalpulkit596 opened this issue May 23, 2019 · 14 comments · Fixed by #260

Comments

@aggarwalpulkit596
Copy link
Contributor

aggarwalpulkit596 commented May 23, 2019

Add A Limit in Settings to for downloading videos preferably a slider with a minimum of 1GB max Up to 10GB

@aggarwalpulkit596 aggarwalpulkit596 changed the title Add Download Limit for videos downloading in Settings Add Download Limit in Settings May 23, 2019
@shubhamofbce
Copy link
Contributor

i would like to work on this issue

@adityastic
Copy link
Contributor

@shubhamofbce and this as well?

@shubhamofbce
Copy link
Contributor

shubhamofbce commented May 28, 2019

Yes i m working on this @adityastic i will tell you for sure if i m unable to make this as i m a newbie .

@adityastic
Copy link
Contributor

@shubhamofbce we all are newbies brother, let us know if you need any help with this. Kudos

@shubhamofbce
Copy link
Contributor

Thanks @adityastic .I will let you know for sure and That statement matters a lot

@shubhamofbce
Copy link
Contributor

shubhamofbce commented May 30, 2019

@aggarwalpulkit596 can you please tell me what action to perform if the download limit is reached??
whether to disconnect the network or pause the download or something else??
download limit

@aggarwalpulkit596
Copy link
Contributor Author

aggarwalpulkit596 commented May 30, 2019

When a limit is reached ask the user to delete previously downloaded videos or delete the video with the oldest date this can be a preference of user

@HardikSo
Copy link

HardikSo commented Jun 2, 2019

is this issue still open?

@adityastic
Copy link
Contributor

@shubhamofbce any updates on this bro?

@shubhamofbce
Copy link
Contributor

@adityastic take this one too. I am busy doing something else. Sorry

@adityastic
Copy link
Contributor

@shubhamofbce ok bro. Thanks :)

@adityastic
Copy link
Contributor

@aggarwalpulkit596 Alright, so how would I calculate the size of the download beforehand?. There is no way yet to calculate size before the file is downloaded

@aggarwalpulkit596
Copy link
Contributor Author

yup there isn't any way to get size beforehand
so we can do it like
if the threshold is 5GB and the user has used 4.5GB so give it a warning to user with the option to delete the oldest file downloaded or cancel current download and usually videos are roughly > 200mb so we can check approx within a limit not the approx size of download but I can ask videocipher team maybe there is a API for that but for now follow this implementation

@adityastic
Copy link
Contributor

Got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants