Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing License section in Readme.md #428

Closed
jddeep opened this issue Oct 9, 2019 · 6 comments
Closed

Missing License section in Readme.md #428

jddeep opened this issue Oct 9, 2019 · 6 comments

Comments

@jddeep
Copy link
Contributor

jddeep commented Oct 9, 2019

Missing "License" section in the Readme file.

Include the License details of this project in its documentation.
This should be present like other substantial open source projects out there.

@jddeep
Copy link
Contributor Author

jddeep commented Oct 9, 2019

@aggarwalpulkit596 @championswimmer Can I work on this?

@aggarwalpulkit596
Copy link
Contributor

GO ahead

@thiagoyeds
Copy link

Hi @jddeep @aggarwalpulkit596
I saw that some of your repositories did not contain the readme license link.
So I decided to create an issue (like here ) and solve it based on that, could you take a look? I wanted to contribute something to get my swags at the Hacktoberfest event

@jddeep
Copy link
Contributor Author

jddeep commented Oct 11, 2019

@ThiagoWhispher Before making a PR. Please see if a PR for the same issue is opened or not. A PR is already opened for this issue at #429 . Please keep this in mind while contributing to projects. Thanks.

@thiagoyeds
Copy link

Hi @jddeep
I'm sorry, I fumbled and ended up doing this duplicate work (I will close the duplicate PR), but I made a similar contribution in another repository ( here ) could you take a look and check if it is valid?

@github-actions
Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants