Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On clicking Leaderboard on the boss website throws error #345

Closed
aannaassalam opened this issue May 23, 2020 · 17 comments · Fixed by #347
Closed

On clicking Leaderboard on the boss website throws error #345

aannaassalam opened this issue May 23, 2020 · 17 comments · Fixed by #347

Comments

@aannaassalam
Copy link
Contributor

BOSS - Google Chrome 5_24_2020 2_22_01 AM

This is the issue that its throwing and it needs a quick fix
@hereisnaman please review this error and assign bounties to this issue so that I can start working on it

@boss-contributions-bot
Copy link

Thanks @aannaassalam, for raising the issue! 🙌

One of our mentors will revert on this soon. ✅

Star ⭐ this project and tweet 🐦 about BOSS 2020.

@aannaassalam
Copy link
Contributor Author

aannaassalam commented May 23, 2020

@hereisnaman please assign my 20 Bounties for raising this issue
I have already given a claim for that

@aannaassalam
Copy link
Contributor Author

I am not able to add a claim for 20 bounties for raising this issue

@prathambatra
Copy link
Contributor

@hereisnaman this is happening because the valid URL is leaderboard/{year} . so you want a new view at /leaderboard to choose year?

@thenamankumar
Copy link
Contributor

I am not able to add a claim for 20 bounties for raising this issue

What is the issue?

@thenamankumar
Copy link
Contributor

@hereisnaman this is happening because the valid URL is leaderboard/{year} . so you want a new view at /leaderboard to choose year?

/leaderboard should render the view for the latest year.

@aannaassalam
Copy link
Contributor Author

I am not able to add a claim for 20 bounties for raising this issue

What is the issue?

Its asking for the link of pull request
Can you assign me bounties without a claim???

@thenamankumar
Copy link
Contributor

I am not able to add a claim for 20 bounties for raising this issue

What is the issue?

Its asking for the link of pull request
Can you assign me bounties without a claim???

You can put the link of the issue there.

@aannaassalam
Copy link
Contributor Author

I am not able to add a claim for 20 bounties for raising this issue

What is the issue?

Its asking for the link of pull request
Can you assign me bounties without a claim???

You can put the link of the issue there.

Done

please review the PR's and merge the one that is appropriate

@thenamankumar
Copy link
Contributor

@aannaassalam @prathambatra the solutions you both provided are wrong.

Here: https://github.com/coding-blocks/boss/pull/347/files#diff-00735162fe7c86f7936aace9c14fc4e6R50 check if the year is undefined and render for 2020.

Because you both tried I'll give 50 points each. Please one of you create a PR for the solution.

@aannaassalam
Copy link
Contributor Author

@aannaassalam @prathambatra the solutions you both provided are wrong.

Here: https://github.com/coding-blocks/boss/pull/347/files#diff-00735162fe7c86f7936aace9c14fc4e6R50 check if the year is undefined and render for 2020.

Because you both tried I'll give 50 points each. Please one of you create a PR for the solution.

Thank you for the points
I will start working on it tomorrow

@prathambatra
Copy link
Contributor

@aannaassalam @prathambatra the solutions you both provided are wrong.

Here: https://github.com/coding-blocks/boss/pull/347/files#diff-00735162fe7c86f7936aace9c14fc4e6R50 check if the year is undefined and render for 2020.

Because you both tried I'll give 50 points each. Please one of you create a PR for the solution.

done. why 50-50 :(

@thenamankumar
Copy link
Contributor

@aannaassalam @prathambatra the solutions you both provided are wrong.
Here: https://github.com/coding-blocks/boss/pull/347/files#diff-00735162fe7c86f7936aace9c14fc4e6R50 check if the year is undefined and render for 2020.
Because you both tried I'll give 50 points each. Please one of you create a PR for the solution.

done. why 50-50 :(

Both of you didn't provide the right solution. I am giving you point just because you tried.

Another option is, I fix it and none of you get any points.

@prathambatra
Copy link
Contributor

@aannaassalam @prathambatra the solutions you both provided are wrong.
Here: https://github.com/coding-blocks/boss/pull/347/files#diff-00735162fe7c86f7936aace9c14fc4e6R50 check if the year is undefined and render for 2020.
Because you both tried I'll give 50 points each. Please one of you create a PR for the solution.

done. why 50-50 :(

Both of you didn't provide the right solution. I am giving you point just because you tried.

Another option is, I fix it and none of you get any points.

okay i will claim 50 only ;)

@prathambatra
Copy link
Contributor

@aannaassalam @prathambatra the solutions you both provided are wrong.
Here: https://github.com/coding-blocks/boss/pull/347/files#diff-00735162fe7c86f7936aace9c14fc4e6R50 check if the year is undefined and render for 2020.
Because you both tried I'll give 50 points each. Please one of you create a PR for the solution.

done. why 50-50 :(

Both of you didn't provide the right solution. I am giving you point just because you tried.
Another option is, I fix it and none of you get any points.

okay i will claim 50 only ;)

merge my PR.

@thenamankumar
Copy link
Contributor

@aannaassalam @prathambatra the solutions you both provided are wrong.
Here: https://github.com/coding-blocks/boss/pull/347/files#diff-00735162fe7c86f7936aace9c14fc4e6R50 check if the year is undefined and render for 2020.
Because you both tried I'll give 50 points each. Please one of you create a PR for the solution.

done. why 50-50 :(

Both of you didn't provide the right solution. I am giving you point just because you tried.
Another option is, I fix it and none of you get any points.

okay i will claim 50 only ;)

merge my PR.

added comments.

@aannaassalam
Copy link
Contributor Author

@hereisnaman will I get my 20 points for raising the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants