Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API throws an error when adding a claim without a PR URL #56

Closed
ananay opened this issue May 15, 2018 · 4 comments
Closed

API throws an error when adding a claim without a PR URL #56

ananay opened this issue May 15, 2018 · 4 comments

Comments

@ananay
Copy link
Contributor

ananay commented May 15, 2018

Claims need to be submitted for only opening issues as well. Since they do not include a PR URL, the application should allow the PR URL field to be left blank.

a) In the case of "/api/claims/add", the server throws an error (shown below)
b) In the case of "/claims/add", the request "freezes up", doesn't add the claim and then cloudflare sends the thing shown below

Request output for a)
image

Request output for b)
image

Proposed solution: Add necessary validation to all the fields and make the PR request field optional.

Apparently, creating too many of these requests on "/claims/add" can be DoS primitive.

@ananay
Copy link
Contributor Author

ananay commented May 15, 2018

@championswimmer
Copy link
Contributor

Why would there be a claim without a PR ?

@ananay
Copy link
Contributor Author

ananay commented May 16, 2018

@championswimmer
According to this #49, there are points for submitting an issue / bug. In this case, we don't have a PR because this is just a filing of an issue so here it doesn't make sense to input anything into the PR field.

@championswimmer
Copy link
Contributor

The newly created issue will be the PR in that case. Mentioned that on gitter and faq.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants