-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hangman.rb doesn't randomize the order of puzzle words #730
Comments
I can see in the source that it shuffles the words to a new array, but the shuffled array isn't used. The WORDS array is still used instead. I'm working on this fix. |
How can I push my fix branch? Do I need to request collaborator status somehow?
I can clone and pull to my heart's delight, so clearly I can read from the remote repo. Something is weird. |
Hi Bill, the common flow is to fork this repository to your account. Then you clone your fork to your local development environment (pc, laptop). You make changes and commits on your local environment then push those back up to your github fork of this repository. Then from github you can easily submit a pull request to merge changes in your fork to this main repository and then when someone reviews it it will be merged or rejected with comment. |
Thanks, @jnellis. I've never had to fork before, so here's to a new thing for me to learn. |
Thanks for noticing this and giving it a fix, BrBill! |
All right, got it forked, and made a pull request from my own repo. |
can this issue be marked as resolved? |
Done! |
Why is it still open? I closed it. Ugh. |
The game in BASIC chooses a random order for the words that are selected for each hangman round. In this ruby implementation, the array of available words is just offered to the player in the order they appear in the source.
The text was updated successfully, but these errors were encountered: