Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counter-intuitive way to send headers #36

Closed
darinrogers opened this issue Feb 21, 2016 · 2 comments
Closed

Counter-intuitive way to send headers #36

darinrogers opened this issue Feb 21, 2016 · 2 comments

Comments

@darinrogers
Copy link
Contributor

It looks like the way to send a header for e.g. a session ID, is by setting option 6 to specify GET or POST. This is counter-intuitive if you're just sending a bunch of GETs and leaving the default. I'd recommend either something in the docs or making headers a separate option.

@tcstool
Copy link
Collaborator

tcstool commented Feb 21, 2016

I agree. I didn't write that part, it was generously contributed It's on
my list of things to clean up, but right now I'm low on free time to get
another release out the door. If you'd like to contribute it would be
greatly appreciated.

On Sun, Feb 21, 2016 at 12:29 PM, Darin Rogers notifications@github.com
wrote:

It looks like the way to send a header for e.g. a session ID, is by
setting option 6 to specify GET or POST. This is counter-intuitive if
you're just sending a bunch of GETs and leaving the default. I'd recommend
either something in the docs or making headers a separate option.


Reply to this email directly or view it on GitHub
#36.

@codingo
Copy link
Owner

codingo commented Aug 22, 2017

@darinrogers @tcstool Closing this issue as this appears to have been merged into master already. Please reply if you believe I have closed this in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants