Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py broken #100

Closed
sky-code opened this issue Sep 24, 2018 · 3 comments
Closed

setup.py broken #100

sky-code opened this issue Sep 24, 2018 · 3 comments

Comments

@sky-code
Copy link
Contributor

sky-code commented Sep 24, 2018

rename NUM_INSTALLED to num_installed

Traceback (most recent call last):
  File "setup.py", line 38, in <module>
    '' if num_installed else 'numpy==1.12.0'],
NameError: name 'num_installed' is not defined

https://github.com/natrix-fork/VHostScan/blob/master/setup.py#L15

https://github.com/natrix-fork/VHostScan/blob/master/setup.py#L38

@codingo
Copy link
Owner

codingo commented Sep 26, 2018

Easy change, going to shelve for HacktoberFest since it's not far away and will help people to get a run on the board. Feel free to contribute back yourself or dm me on twitter (@codingo_) if you would like some help to do so.

@sky-code sky-code mentioned this issue Sep 26, 2018
@konstunn
Copy link

konstunn commented Oct 2, 2018

@codingo, got a fix. Should this issue be closed?

@sky-code
Copy link
Contributor Author

sky-code commented Oct 2, 2018

yep, fixed, issue should be closed.

@sky-code sky-code closed this as completed Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants