Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setup file #16

Closed
codingo opened this issue Sep 19, 2017 · 8 comments
Closed

Add setup file #16

codingo opened this issue Sep 19, 2017 · 8 comments
Labels
enhancement help wanted

Comments

@codingo
Copy link
Owner

codingo commented Sep 19, 2017

Add setup file to add application to $PATH and install dependancies
@codingo codingo added this to the 1.0 Release milestone Sep 19, 2017
@codingo codingo self-assigned this Sep 19, 2017
@codingo codingo removed this from the 1.0 Release milestone Sep 27, 2017
@codingo codingo removed their assignment Sep 27, 2017
@MohitS10
Copy link

MohitS10 commented Oct 5, 2017

Hi. Can i work on this?

@codingo
Copy link
Owner Author

codingo commented Oct 5, 2017

Definitely @MohitS10.

@codingo
Copy link
Owner Author

codingo commented Oct 8, 2017

Hi @MohitS10! How'd you go with this?

@MohitS10
Copy link

MohitS10 commented Oct 8, 2017 •
edited

Hi @codingo ! So i think i have managed to write a setup script that installs the dependencies. Its a simple setup function from the setuptools library. I have no idea what you mean by adding application to $PATH. Do you mean to add the path of the script to the $PATH environment variable?

If that is the case, I should be able to submit a request by tomorrow.

@codingo
Copy link
Owner Author

codingo commented Oct 8, 2017

Yup! I believe aetuptools will handle that but don't know for sure. I can test in a vm for you if you want to pr what you already have and then we can adjust from there?

@MohitS10
Copy link

Sure! I'll PR by tonight.

@MohitS10 MohitS10 mentioned this issue Oct 11, 2017
Closed
@codingo
Copy link
Owner Author

codingo commented Nov 8, 2017

Change for this has now moved to #83

@codingo
Copy link
Owner Author

codingo commented Dec 6, 2017

Closed with #83

@codingo codingo closed this as completed Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codingo @MohitS10