Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] chained unary operators are not pushed correctly to stack #80

Closed
lofcz opened this issue Jan 23, 2021 · 7 comments
Closed

[bug] chained unary operators are not pushed correctly to stack #80

lofcz opened this issue Jan 23, 2021 · 7 comments
Assignees
Labels

Comments

@lofcz
Copy link
Contributor

lofcz commented Jan 23, 2021

Consider these examples:

int a = 0;
a = -~a;
return a; // returns 1 in c#, EE crashes
int a = 0;
a = +-+-+-+-+a;
return a; // returns 0 in c#, EE crashes
int a = 0;
a = a >> +-+-+-+2 << +-+-+-+-2 >> +-+-+-+-+2 << +-+-+-+-+2;
return a; // returns 0 in c#, EE crashes
@codingseb codingseb added the bug label Jan 25, 2021
@codingseb codingseb self-assigned this Jan 25, 2021
@codingseb
Copy link
Owner

OK, I think I never used multiple unary operators until today 🤔.
I will look how to correct that 👍🏻.

@lofcz
Copy link
Contributor Author

lofcz commented Jan 25, 2021

OK, I think I never used multiple unary operators until today 🤔.
I will look how to correct that 👍🏻.

I actually use the first one occasionally to flex on my fellow peers 😄

@lofcz lofcz changed the title [bug] chained unary operators are not pushed correctly to stack [bug] chained unary operators are not pushed correctly to stack Jan 27, 2021
@lofcz
Copy link
Contributor Author

lofcz commented Mar 11, 2021

@codingseb great job with the new features. Should you have some spare time, would you please look into this issue? Thank you!

@codingseb
Copy link
Owner

codingseb commented Mar 12, 2021

OK I think I am close to the solution. Just need to make one or two more tests and I will publish it. It's coming very soon.

@lofcz
Copy link
Contributor Author

lofcz commented Mar 13, 2021

Great job sorting this out! I've tested chained unary operators branch and found no issues.

@codingseb
Copy link
Owner

Great job sorting this out! I've tested chained unary operators branch and found no issues.

@lofcz yes all your examples were already working. I just made it work for custom left operands only operators.

I just published version 1.4.25.0 that manage this issue. Thanks again for all @lofcz

@lofcz
Copy link
Contributor Author

lofcz commented Mar 14, 2021

@codingseb you are the best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants