Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added state code to the address object #64

Merged
merged 1 commit into from Feb 6, 2021
Merged

Added state code to the address object #64

merged 1 commit into from Feb 6, 2021

Conversation

korbenclario
Copy link
Contributor

Hi

I want to use your library, but need State Code in the response. Please, check my solution, I've added state code in all services which provide state code.

I can make additional updates if something wrong.

Otherwise, I'll need to create a map where I'll lookup long names to short, which looks strange for me as logically library can provide these already.

Regards,
Aleksandr

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #64 (a4cc14b) into master (c1d893b) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   79.48%   79.60%   +0.11%     
==========================================
  Files          22       22              
  Lines         702      706       +4     
==========================================
+ Hits          558      562       +4     
  Misses         97       97              
  Partials       47       47              
Impacted Files Coverage Δ
geocod/geocoder.go 82.75% <100.00%> (+0.61%) ⬆️
google/geocoder.go 71.69% <100.00%> (+0.54%) ⬆️
mapbox/geocoder.go 81.57% <100.00%> (+0.49%) ⬆️
mapzen/geocoder.go 75.86% <100.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1d893b...a4cc14b. Read the comment docs.

@codingsince1985 codingsince1985 merged commit 46f392b into codingsince1985:master Feb 6, 2021
@codingsince1985
Copy link
Owner

looks good, hope it suits your case now @korbenclario

@korbenclario korbenclario deleted the state_short_name branch February 8, 2021 10:37
@korbenclario
Copy link
Contributor Author

@codingsince1985 perfectly, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants