Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spot.js throwing errors (out-of-bounds and undefined variables) #18

Closed
TheEyeOfBrows opened this issue Jan 19, 2017 · 2 comments
Closed

Spot.js throwing errors (out-of-bounds and undefined variables) #18

TheEyeOfBrows opened this issue Jan 19, 2017 · 2 comments

Comments

@TheEyeOfBrows
Copy link
Contributor

Looks like the last two merges were incompatible with each other ( #10 and #12 ).

Spot.js is throwing errors when gathering neighbor information (both regular neighbors and wall neighbors). Part of it looks like it's trying to use indexes outside of the grid range.
@ootsby
Copy link
Contributor

ootsby commented Jan 19, 2017

Addressed in pr #19. (I was expecting the reference in the pull request to auto link it to this somehow. Disappointing that it didn't.)

shiffman added a commit that referenced this issue Jan 20, 2017
@shiffman
Merge pull request #19 from ootsby/master
610778b 
Fix/Refactor of neighbor array populating (issue #18)
@TheEyeOfBrows
Copy link
Contributor Author

Fix looks good!

Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ootsby @TheEyeOfBrows