Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline completions - user feedback #432

Closed
dimacodota opened this issue Aug 4, 2021 · 144 comments
Closed

Inline completions - user feedback #432

dimacodota opened this issue Aug 4, 2021 · 144 comments
Labels

Comments

@dimacodota
Copy link
Contributor

dimacodota commented Aug 4, 2021

Hi All, we just released an experimental "inline Completions" feature 🎉

Please share your experience with this feature🙏

In order to enable it:

  • make sure you are using the latest engine(3.5.37) and extension(3.4.21) version.
  • open the Tabnine Home(from the status bar item), scroll to "General Preferences" and check the "inline Completions" option
  • restart vscode

Screen Shot 2021-08-08 at 11 15 14

@rcoundon
Copy link

rcoundon commented Aug 8, 2021

I'm possibly being dumb here but where is Tabnine Home? I can only see the regular VSCode preferences and I don't seem to be able to find anywhere to download the Tabnine engine separately (i.e. only the various extensions) which is what's implied by the instructions.

@dimacodota
Copy link
Contributor Author

I'm possibly being dumb here but where is Tabnine Home? I can only see the regular VSCode preferences and I don't seem to be able to find anywhere to download the Tabnine engine separately (i.e. only the various extensions) which is what's implied by the instructions.

click on the "Tabnine" status bar item:
Screen Shot 2021-08-08 at 12 07 15

@rcoundon
Copy link

rcoundon commented Aug 8, 2021

I'm possibly being dumb here but where is Tabnine Home? I can only see the regular VSCode preferences and I don't seem to be able to find anywhere to download the Tabnine engine separately (i.e. only the various extensions) which is what's implied by the instructions.

click on the "Tabnine" status bar item:
Screen Shot 2021-08-08 at 12 07 15

Great - thank you

@dreambit
Copy link

Does it allow to see one suggestion only?

@dimacodota
Copy link
Contributor Author

Does it allow to see one suggestion only?
you can "list" through the suggestions via alt +[ and alt +] keys

Screen Shot 2021-08-12 at 0 53 11

@StefnirKristjansson
Copy link

I honestly find it better than the popup since I have a lot of snippets that I use the tab space I didn't like the fact that the suggestions crowded out the snippets.

What would be perfect is that I could see the other suggestions somewhere so it don't waste time I circling them with the alt +[

Since I used tabnine to be faster I would like to see it fast if there are any suggestions that I can use.

@xusine
Copy link

xusine commented Aug 18, 2021

When using lens-related plugins like Error lens and Git lens, it breaks Tabnine's autocomplete.

@HippieHosenHustler
Copy link

HippieHosenHustler commented Aug 19, 2021

Looks like a cool feature. It does not seem to work in the IntelliJ Plugin though. Is this something that is in the works?

@Eransho
Copy link

Eransho commented Aug 19, 2021

Looks like a cool feature. It does not seem to work in the IntelliJ Plugin though. Is this something that is in the works?

Yes, we are working on it. It should be released soon

@DenysAshikhin
Copy link

Love this feature when combined with the Full Line completions. However, I have two requests/questions:

  1. Would it be possible to add a switch (or be default) that if we have full line completion turned on, it will instead show its longest prediction first. I just find myself sometimes having to use the 'ctr + [ OR ]' to cycle from completing the current word (which is accurate) to the full line which is a bit cumbersome

  2. Somehow combine inline with a dropdown? Like it would show the first auto-complete suggestion inline, but all other options would appear in a dropdown (either the current drop down style, or a different one).

#2 is key because it shows whether I will waste time cyclying through each one with the hot keys or not.

Other than that, great work!

@IRediTOTO
Copy link

love this feature :)

@laundmo
Copy link

laundmo commented Aug 23, 2021

In VSCode the suggestion sometimes appears in front of the text. Seems to only happen when starting a new line.


fixes itself after waiting for a bit

this might be caused by the fact that the files im working on are on a remote network drive and therefore have limited bandwith and latency, though tabnine really shouldn't need direct file access for individual predictions.

edit:
hmm, also happens with lines when you add closing symbols and then jump before them, so it might not be related to it being a new line

edit 2:
this is happening all the time now. im going to have to turn this great feature off until it stops moving my cursor due to suggestions popping up infront of the cursor, as that is really jarring. it should NEVER move my cursor no matter for how short, which it currently does, see the videos:

stopped typing, you can see the cursor move forwards and back:

jv9vjBc86g.mp4

didn't stop typing:

TctvYlUdZg.mp4

@shmkane
Copy link

shmkane commented Aug 23, 2021

There's occasions where pressing Tab to accept an inline-completion results in either an actual tab being inserted, or it prefers the first option of a dropdown Intellisense suggestion instead.

To prevent the latter, I've completely disabled the dropdowns from VSCode entirely.

However, in this .md file for example, the issue still persists

Screen.Recording.2021-08-23.at.10.26.24.AM.mov

Settings:
image
image

@dimacodota
Copy link
Contributor Author

There's occasions where pressing Tab to accept an inline-completion results in either an actual tab being inserted, or it prefers the first option of a dropdown Intellisense suggestion instead.

To prevent the latter, I've completely disabled the dropdowns from VSCode entirely.

However, in this .md file for example, the issue still persists

Screen.Recording.2021-08-23.at.10.26.24.AM.mov
Settings:
image
image

@shmkane, can you please share your console log (Help -> Toggle Developer Tools) ?

@shmkane
Copy link

shmkane commented Aug 23, 2021

There's occasions where pressing Tab to accept an inline-completion results in either an actual tab being inserted, or it prefers the first option of a dropdown Intellisense suggestion instead.
To prevent the latter, I've completely disabled the dropdowns from VSCode entirely.
However, in this .md file for example, the issue still persists
Screen.Recording.2021-08-23.at.10.26.24.AM.mov
Settings:
image
image

@shmkane, can you please share your console log (Help -> Toggle Developer Tools) ?

Here's me attempting to tab complete on a markdown file vs a javascript file.

Untitled.mov

I'm unsure if the errors displayed are related, but here's a PasteBin of the output shown in the video

@dimacodota
Copy link
Contributor Author

@shmkane - can you please share the list of your installed extensions code --list-extensions?

@shmkane
Copy link

shmkane commented Aug 23, 2021

@shmkane - can you please share the list of your installed extensions code --list-extensions?

code --list-extensions

christian-kohler.npm-intellisense
christian-kohler.path-intellisense
CoenraadS.bracket-pair-colorizer-2
dbaeumer.vscode-eslint
discountry.react-redux-react-router-snippets
donjayamanne.python-extension-pack
eamodio.gitlens
eg2.vscode-npm-script
esbenp.prettier-vscode
janisdd.vscode-edit-csv
jasonnutter.search-node-modules
jawandarajbir.react-vscode-extension-pack
k--kato.intellij-idea-keybindings
KevinRose.vsc-python-indent
magicstack.MagicPython
ms-python.python
ms-python.vscode-pylance
naumovs.color-highlight
njpwerner.autodocstring
richie5um2.vscode-sort-json
rvest.vs-code-prettier-eslint
streetsidesoftware.code-spell-checker
TabNine.tabnine-vscode
VisualStudioExptTeam.vscodeintellicode
vscode-icons-team.vscode-icons
xabikos.JavaScriptSnippets
xabikos.ReactSnippets
yzhang.markdown-all-in-one
zhuangtongfa.material-theme

@xuzhanhh
Copy link

xuzhanhh commented Aug 24, 2021

it seems will quit edit mode and turn to visual mode with vsocde vim in some cases

@lastgosumatt
Copy link

lastgosumatt commented Aug 26, 2021

it seems will quit edit mode and turn to visual mode with vsocde vim in some cases

same for me, but almost all time

@Mattiaslndstrm
Copy link

it seems will quit edit mode and turn to visual mode with vsocde vim in some cases

Yes, almost all the time here too.

@Magnusri
Copy link

Fantastic feature!

I think it would be great if pressing arrow down or up(to select from the regular dropdown list) would disable the feature temporarily to allow tab to pick from the regular dropdown instead.

@hugohabicht01
Copy link

What I personally noticed is that the inline completetions aren't really compatible with the vscode vim plugin (vscodevim.vim). When using a suggested completion by pressing tab, the vim plugin will go into visual mode, the vim cursor stays at the last typed character but a "normal", thin cursor will appear at the end of the completed code. This is quite an annoyance as you can't keep typing but instead need to spam esc to get back into normal mode and then move your cursor to the end again and go into insert mode before you can start typing again.

@shadowndacorner
Copy link

I've experienced the same issues as several others in the thread with this feature with the Vim extension for VS Code.

I also noticed similar issues with the markdown extension breaking tab auto completion as described by @shmkane. Based on my own experience with a simple navigation extension I wrote, it seems like the markdown extension specifically captures input overzealously - I noticed that it broke the backspace keybinding I use in my extension. I've only noticed that behavior when editing markdown files so far. Not sure if that's helpful at all for narrowing down that issue.

As a feature request, it would be nice if there was a way to request inline suggestions, similar to how ctrl+space opens the regular suggestion dropdown.

@frizzant
Copy link

frizzant commented Sep 2, 2021

I sometimes just use Tabnine as a kind of AI-assisted lexicon of what i may need, so I would suggest that it does show the other options too, instead of having to manually expand the other options, I'd like to see the inline suggestion, and the others too.
(PHPStorm)

@jrrmcalcio
Copy link

I can't make it work, when a suggestion appears, i hit tab and just a TAB character appears :( I'm using VSCode 1.59.1, tabnine plugin: 3.4.26 and engine: 3.6.5-40 pro. Any help?

Thank you

@igorsgm
Copy link

igorsgm commented Sep 2, 2021

Does this feature work with Jetbrains at all? I can't make it work on PHPStorm.

@IRediTOTO
Copy link

VS code just release new version inludes inline complete. Should I remove tab9 ? So confuse

@david-morris
Copy link

Hey, I just noticed that TabNine is MIT-licensed. Is there anyone with experience maintaining forks? It would be convenient to have a version of TabNine that did not re-enable inline completion on container rebuild.

@david-morris
Copy link

One thing about when TabNine ignores the preference to not give inline suggestions is that if the setting is set off both locally and in the cloud, when you rebuild a dev container, it will give inline suggestions anyway until you toggle the setting on and off in the settings page.
So there seems to be something wrong with some code somewhere that synchronizes preferences. Maybe there was an assumption about when preferences needed to be read which is violated by rebuilding a container?

@kouhe3
Copy link

kouhe3 commented Jun 15, 2022

image

both inline + popup completion at the same time?

how to fix this bug.

ok, I think I can use

"editor.suggest.preview": true,
"editor.inlineSuggest.enabled": true

@skwaugh
Copy link

skwaugh commented Jun 16, 2022

feedback - I'd like to use Advanced Completions without inline completions. Suggest the Advanced completion first within the popup , but don't make me give up visibility of other suggestions within the Popup edit: I was mistaken!

Under Advanced Completions, there is a Note: This also enables cloud mode.
You should indicate that it also enables/disables Inline Completions, and that you can't have one without the either (or change that :-] )

Thanks!

@jabbalaci
Copy link

I use ZSH as my shell and there the inline completion is the right arrow. I'm used to it and in VS Code I always press it instead of TAB, but it doesn't work as expected.

I tried to add it to keybindings.json:

    {
        "key": "right",
        "command": "tabnine.accept-inline-suggestion",
        "when": "tabnine.in-inline-suggestions && tabnine.inline-suggestion:enabled || tabnine.in-inline-suggestions && tabnine.snippet-suggestion:enabled"
    },

However, no effect. I want the right arrow to function just like the TAB for completing inline suggestions. Thanks.

@haifengkao
Copy link

haifengkao commented Jun 23, 2022

How to disable Inline completions and enable advanced completions at the same time?

@Carleslc
Copy link

I can't see more than one suggestion using inline completions. In my case, the alt +[ and alt +] keys are not working as stated in some comments above.

I'm using VSCode plugin version 3.5.58. I don't see either the tabnine.next-inline-suggestion or tabnine.prev-inline-suggestion in the keyboard shortcuts settings.

Anyone can provide some help on this? Thank you.

@chirag127
Copy link

I can't know if the suggestions are made by GitHub copilot or tab nine when this is enabled. I just enabled it and started to think why the hell GitHub copilot got bad and then found its tab nine.

@laurentpayot
Copy link

laurentpayot commented Jul 6, 2022

When editing a comment in VSCode, the proposed words are the same color as the comment. When editing at the beginning or at the middle of the comment line, it is impossible to distinguish the actual completion from the end of the comment line. It is such a pain that I had to disable inline completions.
IMHO a color picker for the inline completions should be added in preferences.

@saarelad
Copy link

It was probably already mentioned before, but anyway:

When working on intelliJ with live templates configuration, tabnine's inline suggestions overlap the template, see example:

image

@tomdunhamsf
Copy link

This is now required for Advanced Completions, which for me are noticeably better. Could we have an option to place suggestions both in the pop-up and as an inline because:

  1. In practice I will never use Option+[ to cycle through the suggestions. It is too slow for me to see the alternatives, when instead I could just keep typing to get a better suggestion. If the suggestions are in the pop-up, I can see right away if TabNine already has what I want as the second or third option. By placing in inline as well, I will be able to see the full suggestion of whichever option I currently have selected in the pop-up (or the first in the pop-up if I haven't hit the arrow key yet).
  2. Sometime the inline gets jumbled with whatever Intellij wants to write to the side of my cursor, like parameter names. If the suggestion were also in the pop-up, it would help.

Until Advanced Completions, I just used the pop-up. This works fine for me, because even if the suggestions are short, if I can quickly select them, it speeds me up. However, Advanced Completions guess things like what String literal I want to use during testing much better. Frankly, I never really see a multi line match, nor do I need one. If you can correctly guess the rest of a line after a few keystrokes that is good enough for me. So even just allowing Advanced Completion to work with pop-ups would work for me.

I understand that you might want inline for Advanced Completion, so that the programmer can see the full suggestion if it is multiline. I'd suggest just showing the current suggestion as multi-line for this reason, but also displaying the pop-up so that the user can quickly see if there are useful suggestions to cycle to. As an added bonus the programmer just continues to use the same keys as the built-in IDE completion uses.

Note that I also have full line completions enabled, if that makes a difference.

@Creling
Copy link

Creling commented Jul 21, 2022

Well, I need an option to DISABLE inline completions for it breaks the classical workflow that the pop-up gathers all suggestions worth noticing, no matter they come from TabNine, IntelliSense or other extensions.

Tbh, I scarcely have the extra energy to focus on the gray, indistinct sentences produced by Inline Completion. Not to mention these sentences are covered by the pop-up occasionally.

@rbouma
Copy link

rbouma commented Aug 1, 2022

Please how to disable inline completions? really hate it. please remove it and show in the popup box instead as it always was.

@halfelf
Copy link

halfelf commented Aug 1, 2022

How to achieve this ?

[ ] Whole-line code completions
[ ] Full-function code completions
[x] Natural language to code completions
[x] Learns your coding patterns & style

Or, I want to go back to previous version when I could choose between classic completion and inline.

@vincentinttsh
Copy link

vincentinttsh commented Aug 4, 2022

Well, I need an option to DISABLE inline completions for it breaks the classical workflow that the pop-up gathers all suggestions worth noticing, no matter they come from TabNine, IntelliSense or other extensions.

Tbh, I scarcely have the extra energy to focus on the gray, indistinct sentences produced by Inline Completion. Not to mention these sentences are covered by the pop-up occasionally.

I found a way to disable inline completions:

  1. find the location that Tabnine store the config( Type Tabnine::config_dir in your editor to find your configuration directory.)
  2. find a file name tabnine_config.json in that directory and open it
  3. change inline_suggestions_mode to false

P.S. I guess snippets_enabled_v2 in file tabnine_config.json is mean Full-function code completions

@Trapfether
Copy link

Trapfether commented Aug 5, 2022

Hello Again,

A reiteration of a usability Concern I expressed earlier, and an issue related to transparency on this topic.

Per my previous comment, I disabled inline suggestions due to a usability problem. Namely, inline suggestions do not play well with auto-complete options. If I arrow down to select an option from the autocomplete popup and hit tab to select it, tab-nine hijacks that tab press and puts its suggested inline completion instead. This is now compounded by a flaky inline preview issue. The grey text does not always appear when Tab-Nine intends to place an inline completion so I will select an option from the autocomplete dropdown and a completely different completion will appear seemingly out of nowhere.

I would back other comments I have seen here, that autocomplete options need to be placed in the auto-complete modal and inlines disabled by default. In Particular, it should either be an option; or the default, that inline completions are something to be REQUESTED by the user via a shortcut, otherwise, they should be included in the auto-complete popup options instead.

The amount of time wasted fixing mistakes brought about by the inline completions is absurd. In addition to the above usability issues, Tab-Nine highlights the entire completion after hitting the tab to select it, meaning that if I then hit anything other than an arrow, the suggestion I seemingly just selected is now replaced by the new character. So now the keystrokes necessary to work with inline suggestions are a tab to select, an arrow to unhighlight, backspace to the final correct character, and finish the line manually. As opposed to the previous workflow using the suggestion popup, arrow down the list to a correct useful suggestion, hit the tab to select it and go about your day.

Finally, the transparency issue. Everything I described above was the result of inline suggestions turning on without my informed knowledge. I once again found myself in the position of not understanding WHY my workflow was suddenly different and broken. It is now apparent that this is the result of turning on advanced completions. I did so when prompted by Tab-Nine within my editor; however, nowhere during that procedure was it made apparent that turning on said feature would also force inline suggestions to turn on. This is especially irritating when you consider that I had the feature turned OFF in my settings. I should have been alerted to the conflict and been able to make an informed decision about whether to continue. Then when I began experiencing the previously mentioned issues, I would have at least understood where they were coming from and what course of action would correct them.

Once Again, I have disabled advanced completions until these usability issues are resolved. I find Tab-Nine to be useful when it is contained to the completions pop-up; however, the inline completion feature is simply obtrusive with its current implementation. A full rework or some more granular options are NECESSARY for this to be smoothly integrated into my; and seemingly many others, workflows.

Correction: I followed the instructions in the comment made by @vincentinttsh . I found tabnine_config.json inside my Roaming folder on Windows. There is a folder for TabNine, and it was in there. I was able to turn on advanced completions after making this change without the usability issues reoccurring. TabNine does not support multi-line completions in the auto-complete popup however.

@maya-tabnine
Copy link

Hi guys, sorry for not responding here!!
Our team is reading all of your comments, and we will take them into consideration. Every feedback or opinion you share here is brought up to the product and R&D teams so they can improve the Tabnine hub and the whole Tabnine experience going forward to make things better for you.

@oldmansutton
Copy link

oldmansutton commented Aug 12, 2022

I agree with the complaints regarding being forced into inline suggestions without my knowledge. I've been using Tabnine for a
long time now, and have gotten used to the workflow. Yesterday I was coding so fast, today the inline suggestions are now the default and I can't find a way to turn them off. My workflow has been crippled during a time when I NEED to be productive, and I'm spending more time for worse suggestions with the new default. Not happy with Tabnine now at ALL. Changing peoples' accustomed default workflow without their knowledge or consent is NOT cool.

Edit: Kudos to @vincentinttsh for the instructions on how to turn this forced feature off. I think Tabnine is an amazing tool, and now that I'm back to my accustomed workflow, it is useful once again.

Edit2: I take it back. Now with the inline change, and turning it off, I'm only getting one word completions from Tabnine, whereas before I was getting entire lines. Really not impressed with the upgrade.

@david-morris
Copy link

david-morris commented Aug 15, 2022

Hi guys, sorry for not responding here!! Our team is reading all of your comments, and we will take them into consideration. Every feedback or opinion you share here is brought up to the product and R&D teams so they can improve the Tabnine hub and the whole Tabnine experience going forward to make things better for you.

@maya-tabnine , I don't understand. Just today, an automatic tabnine update turned inline completions back on. Is tabnine moving away from providing completions to people who want "just another" completion source?

Furthermore, the settings were changed in a way that I couldn't just turn the inline completions back off. I've noticed that downgrading doesn't restore the old external tabnine settings that let me turn off inline completions.

Inline completions interrupt my cognition and I need to turn off tabnine to get any work done now. This is absolutely an accessibility issue. I am very upset about this. Please honor the accessibility preferences of your users.

@jairdeon
Copy link

Good afternoon.
I've been using Tabnine since its launch and I've been using it together since forever, until the launch of other competitors, which I used or use together.

Today, by coincidence, I noticed that Tabnine is clearly fighting with the other autocomplete AIs, and what caught my attention the most is that the "inline" feature is forcibly active.

I also noticed that apparently the suggestions no longer appear in the popups, and only inline, I also verified that, in the available options of the tabnine, there is no longer the option to "disable online", and or you have all the resources (which includes the inline and multiline padding), or basic padding (also inline).

I particularly feel a loss of productivity because of this, although it is something "futile", but it was how I was used to it since forever. New features are always welcome, but I believe that the user should have the chance to choose what he wants, instead of being "forced" to try a new way of doing something that was already done before (but I respect the business rule chosen by the company).

Some points I noticed

  • Tabnine's settings menu has been drastically reduced, not being possible to customize program parameters (either you have all the features, or partially (Local/Hybrid/Cloud), and being all, they are all, regardless of whether you want to use them or not)
  • Tabnine fights directly with Github Copilot when trying to suggest lines (in the sense that both suggestions appear together), with normally the first "tab" activates one, and then the other
  • When both plugins are active, the other one cannot continue the suggestion made previously (copilot suggests a function, and Tabnine suggests an else for example next)
  • Github copilot offers (in PHPStorm) the option to display your suggestions after pressing a key combination (so you can choose if you want it to display suggestions by default or only after pressing the keys), and in Tabnine it is not possible to apply a criteria for the inline suggestion to appear (although I prefer the traditional popup).

From the above resources, I know that "it is not the plugin's responsibility" to work in conjunction with another AI, and that it is best to use just one. But in my workflow I was always using Github Copilot for inline suggestion (I feel it's less invasive) and Tabnine for suggesting parts of words, strings and parameters (in the popup part), and in my case I was getting great results using the 2 together. But I feel that currently, I'm being "forced" to have to choose just one, since before I was able to evaluate the use of the 2 together in my work model and I would like to continue that way.

Unfortunately what is bothering me the most is the issue of "forcing" the inline, really in my case, the popup suggestion was the most suitable (for my workflow), the non-display of the suggestions in the popup, and the removal of customizing the parameters in the plugin configuration.

The quotes above are made constructively, as I am a big fan of the tool, and I wish to continue using it for its greater purpose which is to increase productivity, regardless of rivalries or alternatives.

@BlueHawk77
Copy link

Good afternoon. I've been using Tabnine since its launch and I've been using it together since forever, until the launch of other competitors, which I used or use together.

Today, by coincidence, I noticed that Tabnine is clearly fighting with the other autocomplete AIs, and what caught my attention the most is that the "inline" feature is forcibly active.

I also noticed that apparently the suggestions no longer appear in the popups, and only inline, I also verified that, in the available options of the tabnine, there is no longer the option to "disable online", and or you have all the resources (which includes the inline and multiline padding), or basic padding (also inline).

I particularly feel a loss of productivity because of this, although it is something "futile", but it was how I was used to it since forever. New features are always welcome, but I believe that the user should have the chance to choose what he wants, instead of being "forced" to try a new way of doing something that was already done before (but I respect the business rule chosen by the company).

Some points I noticed

  • Tabnine's settings menu has been drastically reduced, not being possible to customize program parameters (either you have all the features, or partially (Local/Hybrid/Cloud), and being all, they are all, regardless of whether you want to use them or not)
  • Tabnine fights directly with Github Copilot when trying to suggest lines (in the sense that both suggestions appear together), with normally the first "tab" activates one, and then the other
  • When both plugins are active, the other one cannot continue the suggestion made previously (copilot suggests a function, and Tabnine suggests an else for example next)
  • Github copilot offers (in PHPStorm) the option to display your suggestions after pressing a key combination (so you can choose if you want it to display suggestions by default or only after pressing the keys), and in Tabnine it is not possible to apply a criteria for the inline suggestion to appear (although I prefer the traditional popup).

From the above resources, I know that "it is not the plugin's responsibility" to work in conjunction with another AI, and that it is best to use just one. But in my workflow I was always using Github Copilot for inline suggestion (I feel it's less invasive) and Tabnine for suggesting parts of words, strings and parameters (in the popup part), and in my case I was getting great results using the 2 together. But I feel that currently, I'm being "forced" to have to choose just one, since before I was able to evaluate the use of the 2 together in my work model and I would like to continue that way.

Unfortunately what is bothering me the most is the issue of "forcing" the inline, really in my case, the popup suggestion was the most suitable (for my workflow), the non-display of the suggestions in the popup, and the removal of customizing the parameters in the plugin configuration.

The quotes above are made constructively, as I am a big fan of the tool, and I wish to continue using it for its greater purpose which is to increase productivity, regardless of rivalries or alternatives.

I totally agree with @jairdeon. We should not be forced to use 'one' tool over 'another' even when one of them may be better than the other if there is a way we can use them together.

@yonip23
Copy link
Contributor

yonip23 commented Aug 28, 2022

Hey all,
After taking notes from all your helpful comments, we released a new way to render completions - Hybrid mode.
This is currently available only for JB clients, but we plan on releasing a similar feature in VSCode soon.

This feature renders advanced completions in inline, and basic completions in popup mode.

To enable the feature:

  1. Update to the latest plugin and binary versions - plugin 0.7.21, binary 4.4.123 and higher.
  2. go to the Hub -> Settings -> Additional Settings and enable "Use Hybrid suggestions rendering mode":
    image

This is how it should look like after you enable it:

hybrid-demo.mp4

Thank you all for your valuable feedback, and please let us know how does this work out for you 😃

@jairdeon
Copy link

Hey all, After taking notes from all your helpful comments, we released a new way to render completions - Hybrid mode. This is currently available only for JB clients, but we plan on releasing a similar feature in VSCode soon.

This feature renders advanced completions in inline, and basic completions in popup mode.

To enable the feature:

  1. Update to the latest plugin and binary versions - plugin 0.7.21, binary 4.4.123 and higher.
  2. go to the Hub -> Settings -> Additional Settings and enable "Use Hybrid suggestions rendering mode":
    image

This is how it should look like after you enable it:

hybrid-demo.mp4
Thank you all for your valuable feedback, and please let us know how does this work out for you 😃

Thank you very much, @yonip23, the feature is working perfectly with this update in JB's IDEs.

@susil-py
Copy link

susil-py commented Oct 6, 2022

Hey all, After taking notes from all your helpful comments, we released a new way to render completions - Hybrid mode. This is currently available only for JB clients, but we plan on releasing a similar feature in VSCode soon.

This feature renders advanced completions in inline, and basic completions in popup mode.

To enable the feature:

  1. Update to the latest plugin and binary versions - plugin 0.7.21, binary 4.4.123 and higher.
  2. go to the Hub -> Settings -> Additional Settings and enable "Use Hybrid suggestions rendering mode":
    image

This is how it should look like after you enable it:

hybrid-demo.mp4
Thank you all for your valuable feedback, and please let us know how does this work out for you 😃

Can you implement popup only feature as well. Well I like popup style like previously . Why removing in first place when everything is working well??

@ooliver1
Copy link

ooliver1 commented Dec 4, 2022

I would appreciate if tabnine didn't popup telling me this is an advanced completion every single time it makes a suggestion and I use it.

@Akv2021
Copy link

Akv2021 commented Dec 31, 2022

As an FYI for those who are having issues with markdown (@shmkane for one), the markdown extension has a default keybinding for "tab". Removing that keybinding allowed me to use this correctly.

@dimacodota As for the Vim issues, it seems like this issue may be the cause, but that definitely isn't certain. That may just be an issue of a conflicting keybinding as well.

Can't seem to make it work. Could you please share which keybinding should be overridden ?

@Jancera
Copy link

Jancera commented Feb 16, 2023

I was having a problem with inline suggestions and vscodevim extension, so I tried the solutions proposed by @adanylkov and @finnmerlett but without results. So what I did was disable all my extensions and let only vscodevim and tabnine and in order to fix the inline suggestion acceptance by pressing Tab I just had to add that to my keybidings.json.

{
    "key": "tab",
    "command": "-tabnine.tab-override",
    "when": "suggestWidgetHasFocusedSuggestion && suggestWidgetVisible && tabnine.tab-override && textInputFocus"
  }

With that, I came back enabling my extensions and I let some of those disabled, so I do not know if that problem is related to another extension that is messing with the Tab pressing or if it is related to the setting that I added, or both :)

Hope it helps!

@stale
Copy link

stale bot commented Apr 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 17, 2023
@stale stale bot closed this as completed Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests