New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit pre-alloc size #5

Closed

vlopes11 opened this issue Oct 24, 2021 · 1 comment

Member

vlopes11 commented Oct 24, 2021

Currently, the implementation trusts the provided message and pre-alloc bytes before reading the buffer.

The implementation should either pre-alloc if, and only if, the reader is guaranteed to have enough bytes, or pre-alloc smaller amounts.

Naive pre-alloc may allow malicious users to DDoS

Member Author

vlopes11 commented Jun 7, 2023

Fixed in https://github.com/codx-dev/msgpacker/releases/tag/v0.4.0

vlopes11 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment