Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch away from using PSConsoleHostReadLine #17

Open
codyduong opened this issue Jan 4, 2024 · 3 comments
Open

Switch away from using PSConsoleHostReadLine #17

codyduong opened this issue Jan 4, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@codyduong
Copy link
Owner

Is this a breaking change? Whatever, we'll increment it as a enhancement.

PSConsoleHostReadLine is fragile, and upon Import-Module or Remove-Module it can possibly destroy user personalizations, seek to use something else.

@codyduong codyduong added the enhancement New feature or request label Jan 4, 2024
@codyduong codyduong self-assigned this Jan 4, 2024
@codyduong
Copy link
Owner Author

For context this is where alias-tips gets its original pre-exec hook from: PowerShell/PowerShell#14484 (comment)

@codyduong
Copy link
Owner Author

In #26, we workaround this by adding a message and pasting a simple command to the user output when alias-tips is removed. Given the lifecycle of the module is always typically equivalent to the entire shell lifecycle (since as a productivity tool, its not being unloaded/loaded), this is the best solution (for now). I will keep this open, since they're aren't many issues in this repo if a pre-exec hook ever comes around.

@codyduong
Copy link
Owner Author

This is another thing holding back #10, I'm not super sure how to prevent the line from being run (it is possible, but it waits on user input) before moving onto next prompt. TODO investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant