Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpackOptions.output.publicPath should be configurable #337

Closed
sechel opened this issue Aug 10, 2018 · 6 comments
Closed

webpackOptions.output.publicPath should be configurable #337

sechel opened this issue Aug 10, 2018 · 6 comments

Comments

@sechel
Copy link

sechel commented Aug 10, 2018

Hi there,

some time ago (in 0616dda) you decided to switch from a static webpackOptions.output.publicPath, i.e., /_karma_webpack_/... to a dynamic, but existing on disk, temporary folder on the system.

This poses problems to my setup as I am testing OAuth2 consent flow using the real-world endpoints. In this setup I cannot use a dynamic redirect URLs as the redirect_url has to be registered with the identity provider in advance and has to match literally.

Here is a suggestion: Why not make the value inserted before _karma_webpack_ here
https://github.com/webpack-contrib/karma-webpack/blob/1ac16eaa7b11ee154a2127d4f03cbfd1a81533f6/src/karma-webpack.js#L64
configurable?

Greetings
Stefan

@neben
Copy link

neben commented Dec 6, 2018

Has there been any progress on this?

@danielhusar
Copy link

danielhusar commented Jan 2, 2019

+1 I would like the output path to be configurable as well. Would you accept PRs ?

@matthieu-foucault
Copy link
Collaborator

I would welcome a PR!

@sechel
Copy link
Author

sechel commented Mar 14, 2019

Thanks for fixing it in 4.0.0-rc.2. 😀

@sechel
Copy link
Author

sechel commented Mar 14, 2019

Nevertheless would it be great to have the parameter configurable.

@codymikol codymikol modified the milestones: 4.0.0, 5.1.0 Feb 3, 2021
@codymikol
Copy link
Owner

Closing as this is possible in 5.0.0 and has unit tests to prove that the publicPath is passed along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants