Add support for string and float user properties in UDMF things #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good to me.
Not sure about addition of PType::isString(), usually this check is written as var->Type == TypeString.
It will be great if you post about this PR in the corresponding topic or in Code submission subforum.
|
Corrected that, also added corresponding support for setting string vars in ACS. Updated test map: Thanks for the feedback, I will be able to post on the forums later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the UDMF parser only accepted integer values for thing properties prefixed with "user_", even though strings and floats were supported in linedef/sidedef/sector properties. With this patch things support those extra types now too.
Test map: udmfusertest.zip