LineTracer interface 3D floors fix #467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a gross hack that makes it use two passes for sectors that have 3D floors, so it retains the original GZDoom execution flow while not requiring raw LineFlags manipulation.
The current behavior is as follows:
This fix should not affect normal engine functioning because this path only activates with TRACE_3DCallback flag (which is currently only set in the ZScript interface).
Resolves #415, but properly.
Test case: http://www.mediafire.com/file/25o3z54y5z9bvml/trace3dfloor_test_zzyzx.wad
P.S. I had other ideas of how to do it, but it's too dangerous and can break other uses of this function.
So for compatibility I just added a slight deviation from normal flow activated by variable.