Fix OPL Synth note cutoffs and issues after removal of MusLib #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix bug reported in https://forum.zdoom.org/viewtopic.php? f=104&t=56682. There were two problems: 1. Algorithm to select a free voice was not appropriate. Changed to a simple "least-recently-freed voice" algorithm. 2. Sustained voices were treated as used voices and never got replaced. Now sustained voices are preferentially replaced when there are no free voices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix bug reported in https://forum.zdoom.org/viewtopic.php?
f=104&t=56682.
There were two problems:
simple "least-recently-freed voice" algorithm.
Now sustained voices are preferentially replaced when there are no free
voices.