Update level_compatibility.zs #973
Conversation
Map fixes for some older mods
|
Can you please add links to the mods? They are mainly obscure so I cannot check what was done here. |
|
Yes, sir! If there any objections to including any of these mods in level_compatibility, I am perfectly willing to host my fixes personally in user-made patches, which are thankfully now possible with the advent of the level_postprocessor. |
There was a problem hiding this comment.
I would say that if it’s impossible (or much harder) do finish map without cheating, or if it’s impossible to get 100% kills/items/secrets, then it’s OK to include fixes to internal compatibility.
Without playing a map, and/or without checking with an editor sometimes, is it worth including or not.
Also, do you have a spacebar broken on the keyboard? It would be nice to have whole file formatted consistently, i.e. a space after comma, a space after //, and so on.
I hardly feel that level of attitude was warranted... but fine, I can add spaces after commas and comments if it will make you happy. |
|
No offense, but let’s not forget that the code is mostly read, not written. The thing is how it was written does matter. If it’s hard to read, then it was written poorly. |
|
I genuinely find spaces after commas make code harder to read. In addition to wasting filespace; sometimes every byte can matter. However I do agree with you that consistency is important, and since the existing body of the file follows those conventions, I can adapt my commit to match. After all, I even followed along with adding braces around the body of each Case, even though that doesn't follow any conventions I'm aware of for Switch statements. |
Spaces around commas and comment markers, to better match the rest of the file
|
I'm going to go ahead and take this one since it seems pretty harmless. If I am wrong the changes can always be undone. |
* Update level_compatibility.zs Map fixes for some older mods * Formatting changes Spaces around commas and comment markers, to better match the rest of the file
* Update level_compatibility.zs Map fixes for some older mods * Formatting changes Spaces around commas and comment markers, to better match the rest of the file
Map fixes for some older mods