Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating tasks with same name in different topics, one is replaced by another #42

Open
kolayne opened this issue Nov 2, 2020 · 2 comments

Comments

@kolayne
Copy link

kolayne commented Nov 2, 2020

I am not familiar with the teacher's UI of MathBattle (I would be able to describe the issue in more detail if I could have my own sandbox, see #41), but it seems like when a teacher creates two different tasks with the same name in two different topics, they merge into one task displayed on both topics. I'm pretty sure it's not the expected behavior. I guess the architecture of the project is such that tasks and topics are separate from each other and topics are just groups of tasks that don't acquire them, so the same task can be added to multiple topics. If I'm correct, I think the best solution is to display an error for a teacher that the task with the name he/she is trying to add already exists. If I misunderstood the architecture and two tasks with the same name should be able to coexist, then it should be resolved by just preventing two tasks from merging.

@CoffeBee
Copy link
Owner

CoffeBee commented Nov 2, 2020

Thank you for submitting issues. The problem not in architecture of date stored in the MathBattle. It's problem of routing, we route tasks by them names, but not by their entries in themes. We work on it.

@kolayne
Copy link
Author

kolayne commented Nov 12, 2020

(Didn't open a new issue, because I think the problem is close enough with this to be described within the same issue. Tell me if I'm wrong)

When I am on a topic page and open a task (i.e. go to task page), I want to have a link/button for bringing me back to the topic page I came from. I noticed you have a path on the top of pages, which updates each time I go somewhere and each element of the path is a link to a page I could want to return to. But when I open a task, the path seems to break (?). My root remains the same ("Темы"), but its child is updated (the topic name is replaced with "Задачи") (however, it shouldn't because I kept going deeper to the website, I didn't go back), which is not a link at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants