Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nurse command is not working as should #233

Open
vincenzopalazzo opened this issue Feb 7, 2024 · 2 comments · May be fixed by #239
Open

nurse command is not working as should #233

vincenzopalazzo opened this issue Feb 7, 2024 · 2 comments · May be fixed by #239
Assignees
Labels
🐛 - bug Something isn't working P-hight Hight Priotity issue
Milestone

Comments

@vincenzopalazzo
Copy link
Contributor

vincenzopalazzo commented Feb 7, 2024

I think the following cases is missing by the coffee nurse command

➜  ~ coffee --network testnet remote add folgore-git https://github.com/coffee-tools/folgore.git
✗ Fetch remote from https://github.com/coffee-tools/folgore.git error: Error while add remote: code: 1, msg: '/home/vincent/.coffee/repositories/folgore-git' exists and is not an empty directory
✗ Error: code: 1, msg: '/home/vincent/.coffee/repositories/folgore-git' exists and is not an empty directory
➜  ~ coffee --network testnet nurse
✓ Coffee configuration is not corrupt! No need to run coffee nurse

cc @tareknaser

I think we should trust our database, and if in the database there is nothing we wipe everything there is on disk. What do you think?

@vincenzopalazzo vincenzopalazzo added the 🐛 - bug Something isn't working label Feb 7, 2024
@vincenzopalazzo vincenzopalazzo added this to the 0.1-rc1 milestone Feb 7, 2024
@tareknaser
Copy link
Collaborator

Yes this can happen for various reasons.
It's possible coffee remote add failed midway while cloning the repository. This might have left /home/vincent/.coffee/repositories/folgore-git in an incomplete state.

I will work on adding this case to coffee nurse

@vincenzopalazzo
Copy link
Contributor Author

I think the problem is related to the repository global directory, I should finish #239 before spending time into debugging this

@vincenzopalazzo vincenzopalazzo added the P-hight Hight Priotity issue label Apr 11, 2024
@vincenzopalazzo vincenzopalazzo self-assigned this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 - bug Something isn't working P-hight Hight Priotity issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants